Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trait for audio and podcast. #550

Merged
merged 8 commits into from
Dec 16, 2024
Merged

Add trait for audio and podcast. #550

merged 8 commits into from
Dec 16, 2024

Conversation

gunnarvelle
Copy link
Member

@gunnarvelle gunnarvelle commented Nov 28, 2024

Audio og podkast som egenskaper på artikkel

@gunnarvelle gunnarvelle requested a review from a team November 28, 2024 07:33
@gunnarvelle gunnarvelle marked this pull request as draft November 28, 2024 07:57
@gunnarvelle gunnarvelle changed the title Add trait for audio and file. Add trait for audio and podcast. Dec 13, 2024
@gunnarvelle gunnarvelle marked this pull request as ready for review December 13, 2024 10:44
Copy link
Contributor

@jnatten jnatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, bare et spørsmål 🤓

case _ => // Do nothing
case "audio" => traits += SearchTrait.Audio
case "podcast" => traits += SearchTrait.Podcast
case _ => // Do nothing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er det egentlig noen grunn til at vi ikke bare kan indeksere alt og bruke typene fra validation?

@gunnarvelle gunnarvelle merged commit 8fea001 into master Dec 16, 2024
7 checks passed
@gunnarvelle gunnarvelle deleted the expand-search-traits branch December 16, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants