fix: Apply max_time_hr to sample_level_ibd rule (issue #334)
#342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ``sample_level_ibd`` rule within the ``sample_qc.smk`` sub-workflow needs the ``max_time_hr`` feature applied to it too because it is quite time-intensive. We also updated the description in the ``workflow_params.py`` file to state all of the rules that this feature applies to.
jaamarks
added a commit
that referenced
this pull request
Oct 3, 2024
feat: Apply ``max_time_hr`` to sample_level_ibd rule (issue #334) **What** - Apply the ``max_time_hr`` feature to the ``sample_level_ibd`` rule within the ``sample_qc.smk`` sub-workflow. - Update the ``workflow_params.py`` file to state all of the rules that ``max_time_hr`` affects. **Why** - The ``sample_level_ibd`` rule is another time-intensive step in the pipeline, and can users have experienced timeout issues at this step when running it on large datasets with the standard time-allocation method. So this update ensures that if a user specifies ``max_time_hr`` in the ``config.yml``, it will allso apply to this rule. This is an extension of PR #335 Fixes #334
jaamarks
changed the title
max_time_hr to sample_level_ibd rule (issue #334)max_time_hr to sample_level_ibd rule (issue #334)
jaamarks
changed the title
max_time_hr to sample_level_ibd rule (issue #334)max_time_hr to sample_level_ibd rule (issue #334)
jaamarks
changed the title
max_time_hr to sample_level_ibd rule (issue #334)max_time_hr to sample_level_ibd rule (issue #334)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
max_time_hrfeature to thesample_level_ibdrule within thesample_qc.smksub-workflow.workflow_params.pyfile to state all of the rules thatmax_time_hraffects.Why
The
sample_level_ibdrule is another time-intensive step in the pipeline, and can users have experienced timeout issues at this step when running it on large datasets with the standard time-allocation method. So this update ensures that if a user specifiesmax_time_hrin theconfig.yml, it will allso apply to this rule.This is and extension of PR #335.
Fixes #334