Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add data dictionary for QC_Report to delivery folder (issue #313) #317

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

jaamarks
Copy link
Collaborator

@jaamarks jaamarks commented Aug 28, 2024

This PR introduces a data dictionary to the delivery folder, providing clear definitions for the variables used in the following QC report sheets:

  • SAMPLE_QC
  • SAMPLE_CONCORDANCE
  • SUBJECT_QC
  • ANCESTRY

By having this data dictionary readily available, users can easily understand the meaning and purpose of each column in the QC report, enhancing its usability and interpretation.


Fixes #313

- Created a function in config.py to get the full path of the Data Dictionary in the reporting directory.
- Updated delivery.smk to use this function, adding a new rule for copying the Data Dictionary to the final `delivery/` directory.
- Applied formatting fixes based on pre-commit hooks.
@jaamarks jaamarks changed the title enhancement: Create Data Dictionary for QC_Report.xlsx Sheets (Issue #313) enhancement: Add data dictionary for QC_Report to delivery folder (Issue #313) Aug 28, 2024
@jaamarks jaamarks merged commit 5cf67de into default Aug 28, 2024
2 checks passed
@jaamarks jaamarks deleted the issue-313-data-dict branch September 13, 2024 18:24
@jaamarks jaamarks changed the title enhancement: Add data dictionary for QC_Report to delivery folder (Issue #313) enhancement: Add data dictionary for QC_Report to delivery folder (issue #313) Oct 2, 2024
@jaamarks jaamarks changed the title enhancement: Add data dictionary for QC_Report to delivery folder (issue #313) feat: Add data dictionary for QC_Report to delivery folder (issue #313) Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Data Dictionary for QC Report
1 participant