Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summary table 4a/4b: Unknown samples not counted #240

Closed
1teaspoon opened this issue Mar 14, 2023 · 2 comments
Closed

Summary table 4a/4b: Unknown samples not counted #240

1teaspoon opened this issue Mar 14, 2023 · 2 comments
Assignees
@jaamarks
Labels
bug Something isn't working

Comments

@1teaspoon
Copy link
Contributor

1teaspoon commented Mar 14, 2023 •
edited
Loading

Summary table 4a/4b when there are samples with Case/Control status = 'U', these samples are not counted in the table.
@1teaspoon 1teaspoon added the bug Something isn't working label Mar 14, 2023
@1teaspoon 1teaspoon changed the title Summary table 4a Unknown samples not counted Table 1 and Summary table 4a/4b: Unknown samples not counted Mar 14, 2023
@1teaspoon 1teaspoon changed the title Table 1 and Summary table 4a/4b: Unknown samples not counted Summary table 4a/4b: Unknown samples not counted Mar 14, 2023
@1teaspoon
Copy link
Contributor Author

When Case/Control_status =' ' or 'Unknown', these sample counts should be reflected in the 'Other' column in 4a/4b

@ngaddis
Copy link

ngaddis commented Nov 30, 2023

Summary table is in output Word document. Empty case/control status treated as unknown.

@jaamarks jaamarks self-assigned this Jan 30, 2024
jaamarks added a commit that referenced this issue Feb 29, 2024
@jaamarks
Fixes #240: convert alt case/control labels to Unknown
0428f25
jaamarks added a commit that referenced this issue Mar 1, 2024
@jaamarks
Fixes #240: convert alt case/control labels to Unknown
c3eb774
@jaamarks jaamarks linked a pull request Mar 6, 2024 that will close this issue
Fixes #240: convert alt case/control labels to Unknown #267
Merged
@jaamarks jaamarks removed a link to a pull request Mar 6, 2024
Fixes #240: convert alt case/control labels to Unknown #267
Merged
jaamarks added a commit that referenced this issue Mar 11, 2024
@jaamarks
Merge pull request #267 from NCI-CGR/capture-unknown-case-controls
7826c64 
Fixes #240: convert alt case/control labels to Unknown
@jaamarks jaamarks mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaamarks jaamarks

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ngaddis @1teaspoon @jaamarks