Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modal dialogs with large contents #4602

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Dec 13, 2023

Make sure modal dialogs with (potentially) large contents, like assessments or related object notes, scroll properly.

Closes AB#889

User changes

  • Modal dialogs with large contents now scroll properly if the contents don't fit on the screen.

Superuser changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten marked this pull request as ready for review December 13, 2023 14:46
@gjvoosten gjvoosten force-pushed the AB-889-fix-large-assessment-dialog branch from 884b789 to 06655e6 Compare December 20, 2023 15:54
Make sure modal dialogs with (potentially) large contents,
like assessments or related object notes, scroll properly.
@midmarch midmarch merged commit 2c6e8ff into main Jan 10, 2024
23 checks passed
@midmarch midmarch deleted the AB-889-fix-large-assessment-dialog branch January 10, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants