Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dictionary settings to make report approval workflow optional #4600

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Dec 13, 2023

When so defined in the dictionary, the report approval workflow and/or report planning approval workflow can be made optional.

Closes AB#997

User changes

  • None

Superuser changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
    Add a dictionary entry like this:
    reportWorkflow:
      optionalApprovalWorkflow: false
      optionalPlanningApprovalWorkflow: true
    
    for backwards-compatibility with previous behaviour.
    Setting optionalApprovalWorkflow to true makes the report approval workflow optional; this means that you don't have to set a default approval organization in the admin settings, or (when set) that you don't have to define an approval workflow for the default approval organization.
    Setting optionalPlanningApprovalWorkflow to false makes the planning approval workflow required.
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten marked this pull request as ready for review December 13, 2023 13:23
@gjvoosten gjvoosten force-pushed the AB-997-allow-optional-approval-workflow branch from 9abd3d2 to b1f07a6 Compare December 13, 2023 13:49
@gjvoosten gjvoosten changed the title Add dictionary setting to make report approval workflow optional Add dictionary settings to make report approval workflow optional Dec 13, 2023
@gjvoosten gjvoosten force-pushed the AB-997-allow-optional-approval-workflow branch from b1f07a6 to 187d3f5 Compare December 20, 2023 15:55
@midmarch midmarch merged commit d8113c0 into main Jan 10, 2024
23 checks passed
@midmarch midmarch deleted the AB-997-allow-optional-approval-workflow branch January 10, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants