Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the distinction between advisors and principals #4381

Merged
merged 10 commits into from
Jan 25, 2024

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Jun 28, 2023

ANET distinguished between Advisors and Principals, but in practice this distinction doesn't always work: people can be on either side, so they could be advising or be an interlocutor, depending on context. This distinction is now removed, which means there are now flat lists of people, positions and organizations. Also the term "principal" is now avoided, and replaced by the more generic "interlocutor".

Closes AB#728

User changes

  • The most important change is that report attendees can be moved freely between the Advisors and Interlocutors sections.

Superuser changes

  • The most important change is that organizations no longer have a type (which was either Advisor or Principal), and that the original position types Advisor and Principal are now replaced by a single type Regular.

Admin changes

  • The most important change is that people get a new property, user, which (when true) indicates that they can access ANET (i.e. login).

System admin changes

  • anet.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten force-pushed the AB-728-drop-advisor-principal-distinction-poc branch 4 times, most recently from 378216f to 8aa44c8 Compare July 5, 2023 15:02
@gjvoosten gjvoosten force-pushed the AB-728-drop-advisor-principal-distinction-poc branch 7 times, most recently from 369d53b to af844b1 Compare July 17, 2023 10:05
@gjvoosten gjvoosten force-pushed the AB-728-drop-advisor-principal-distinction-poc branch 2 times, most recently from e707e86 to dd90ae9 Compare July 20, 2023 14:17
@gjvoosten gjvoosten force-pushed the AB-728-drop-advisor-principal-distinction-poc branch 6 times, most recently from 2efc235 to e659e1c Compare August 9, 2023 06:45
@gjvoosten gjvoosten force-pushed the AB-728-drop-advisor-principal-distinction-poc branch 3 times, most recently from 83648a9 to 2c34259 Compare August 16, 2023 12:52
@gjvoosten gjvoosten force-pushed the AB-728-drop-advisor-principal-distinction-poc branch 3 times, most recently from 1308abf to 6b7514b Compare August 23, 2023 12:23
@gjvoosten gjvoosten force-pushed the AB-728-drop-advisor-principal-distinction-poc branch from 6b7514b to 19ed53e Compare August 24, 2023 08:46
@gjvoosten gjvoosten force-pushed the AB-728-drop-advisor-principal-distinction-poc branch 2 times, most recently from 409d366 to ec54126 Compare September 13, 2023 15:27
@gjvoosten gjvoosten force-pushed the AB-728-drop-advisor-principal-distinction-poc branch from ec54126 to 8bfede5 Compare September 21, 2023 12:45
@gjvoosten gjvoosten force-pushed the AB-728-drop-advisor-principal-distinction-poc branch from e0f1617 to a62d130 Compare December 13, 2023 07:40
@gjvoosten gjvoosten force-pushed the AB-728-drop-advisor-principal-distinction-poc branch 2 times, most recently from b22c142 to 389035f Compare December 21, 2023 16:54
@gjvoosten gjvoosten force-pushed the AB-728-drop-advisor-principal-distinction-poc branch 3 times, most recently from f36aab3 to ac2ec0f Compare January 10, 2024 15:33
@gjvoosten gjvoosten marked this pull request as ready for review January 11, 2024 16:08
@gjvoosten gjvoosten force-pushed the AB-728-drop-advisor-principal-distinction-poc branch 3 times, most recently from 2d38ea9 to 8cc6143 Compare January 16, 2024 12:16
@gjvoosten gjvoosten force-pushed the AB-728-drop-advisor-principal-distinction-poc branch 2 times, most recently from f62a3e4 to 5f2d168 Compare January 22, 2024 15:37
@gjvoosten gjvoosten changed the base branch from main to develop January 25, 2024 15:27
@gjvoosten gjvoosten force-pushed the AB-728-drop-advisor-principal-distinction-poc branch from 5f2d168 to bb89857 Compare January 25, 2024 15:33
@gjvoosten gjvoosten merged commit 957b96b into develop Jan 25, 2024
11 checks passed
@gjvoosten gjvoosten deleted the AB-728-drop-advisor-principal-distinction-poc branch January 25, 2024 15:52
gjvoosten added a commit that referenced this pull request Jan 29, 2024
gjvoosten added a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant