-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop the distinction between advisors and principals #4381
Merged
gjvoosten
merged 10 commits into
develop
from
AB-728-drop-advisor-principal-distinction-poc
Jan 25, 2024
Merged
Drop the distinction between advisors and principals #4381
gjvoosten
merged 10 commits into
develop
from
AB-728-drop-advisor-principal-distinction-poc
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjvoosten
force-pushed
the
AB-728-drop-advisor-principal-distinction-poc
branch
4 times, most recently
from
July 5, 2023 15:02
378216f
to
8aa44c8
Compare
gjvoosten
force-pushed
the
AB-728-drop-advisor-principal-distinction-poc
branch
7 times, most recently
from
July 17, 2023 10:05
369d53b
to
af844b1
Compare
gjvoosten
force-pushed
the
AB-728-drop-advisor-principal-distinction-poc
branch
2 times, most recently
from
July 20, 2023 14:17
e707e86
to
dd90ae9
Compare
gjvoosten
force-pushed
the
AB-728-drop-advisor-principal-distinction-poc
branch
6 times, most recently
from
August 9, 2023 06:45
2efc235
to
e659e1c
Compare
gjvoosten
force-pushed
the
AB-728-drop-advisor-principal-distinction-poc
branch
3 times, most recently
from
August 16, 2023 12:52
83648a9
to
2c34259
Compare
gjvoosten
force-pushed
the
AB-728-drop-advisor-principal-distinction-poc
branch
3 times, most recently
from
August 23, 2023 12:23
1308abf
to
6b7514b
Compare
gjvoosten
force-pushed
the
AB-728-drop-advisor-principal-distinction-poc
branch
from
August 24, 2023 08:46
6b7514b
to
19ed53e
Compare
gjvoosten
force-pushed
the
AB-728-drop-advisor-principal-distinction-poc
branch
2 times, most recently
from
September 13, 2023 15:27
409d366
to
ec54126
Compare
gjvoosten
force-pushed
the
AB-728-drop-advisor-principal-distinction-poc
branch
from
September 21, 2023 12:45
ec54126
to
8bfede5
Compare
gjvoosten
force-pushed
the
AB-728-drop-advisor-principal-distinction-poc
branch
from
December 13, 2023 07:40
e0f1617
to
a62d130
Compare
gjvoosten
force-pushed
the
AB-728-drop-advisor-principal-distinction-poc
branch
2 times, most recently
from
December 21, 2023 16:54
b22c142
to
389035f
Compare
gjvoosten
force-pushed
the
AB-728-drop-advisor-principal-distinction-poc
branch
3 times, most recently
from
January 10, 2024 15:33
f36aab3
to
ac2ec0f
Compare
gjvoosten
force-pushed
the
AB-728-drop-advisor-principal-distinction-poc
branch
3 times, most recently
from
January 16, 2024 12:16
2d38ea9
to
8cc6143
Compare
gjvoosten
force-pushed
the
AB-728-drop-advisor-principal-distinction-poc
branch
2 times, most recently
from
January 22, 2024 15:37
f62a3e4
to
5f2d168
Compare
On the left-hand side of PendingAssessments, only ANET users should be considered.
Add test conditions so assessments apply to the correct set of people.
gjvoosten
force-pushed
the
AB-728-drop-advisor-principal-distinction-poc
branch
from
January 25, 2024 15:33
5f2d168
to
bb89857
Compare
gjvoosten
added a commit
that referenced
this pull request
Jan 29, 2024
gjvoosten
added a commit
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANET distinguished between Advisors and Principals, but in practice this distinction doesn't always work: people can be on either side, so they could be advising or be an interlocutor, depending on context. This distinction is now removed, which means there are now flat lists of people, positions and organizations. Also the term "principal" is now avoided, and replaced by the more generic "interlocutor".
Closes AB#728
User changes
Superuser changes
Admin changes
user
, which (when true) indicates that they can access ANET (i.e. login).System admin changes
Checklist
repo#issue: Title
title format and these 7 rules