Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation constraint queries #164

Open
tursynay opened this issue Jul 22, 2021 · 12 comments
Open

Implementation constraint queries #164

tursynay opened this issue Jul 22, 2021 · 12 comments
Assignees

Comments

@tursynay
Copy link
Contributor

Each aras should be assigned, if they cannot do it, they can call it out of scope and we can assign them later.

@tursynay
Copy link
Contributor Author

tursynay commented Jul 29, 2021

Workflow query A.1 - write a query with a TRAPI constraint with a chemical that must be FDA approved. Along the way ARAs and ARS will then know what to do. Currently none of the ARAs are implementing constraints. The idea is to have the ARAs implement the constraint. There is a backup plan that this constraint can be implemented with workflow runner and then ARAs don't have to worry about it. But before the backup plan is implemented, ARAs need to evaluate and determine if implementing the constraint is out of scope for them. @vgardner-renci, assign all ARAs to this issue so they can make a decision.

@andrewsu
Copy link
Contributor

andrewsu commented Aug 4, 2021

BTE is planning on implementing constraint filtering, tracked in biothings/biothings_explorer#174

@amykglen
Copy link

amykglen commented Aug 4, 2021

ARAX is planning to have this constraint implemented by Aug. 20 - being tracked in RTXteam/RTX#1599

@webyrd
Copy link

webyrd commented Aug 5, 2021

Will triage by August 12, 2021. We have some limited constraint capabilities already. I need to investigate what else we'd need to add.

@tursynay
Copy link
Contributor Author

tursynay commented Aug 5, 2021

In the mini hackathon repo, there is a folder with code EFGR advanced.

@cbizon
Copy link
Collaborator

cbizon commented Aug 5, 2021

This is in-scope for ranking-agent. Being tracked: ranking-agent/strider#233

@andrewsu
Copy link
Contributor

andrewsu commented Aug 5, 2021

@vgardner-renci
Copy link
Contributor

Improving Agent and Explanatory Agent folks, can you comment on this issue @brettasmi @jenndoug @suihuang-ISB @Rosinaweber

@amykglen
Copy link

ARAX has implemented handling of the biolink:highest_FDA_approval_status constraint (as defined in A.9_EGFR_advanced.json) - an example of a query using it is here: https://arax.ncats.io/?r=19693

Has there been a discussion about what possible values other than "regular approval" this constraint might have? We have other drug status information like "experimental drug" or "investigational drug" that could be constrained on as well, but are not sure if a standard way of creating constraints for such info has been settled on.

@webyrd
Copy link

webyrd commented Aug 26, 2021

Will implement by the relay.

@cbizon
Copy link
Collaborator

cbizon commented Sep 8, 2021

Strider being deployed Sep 9 should implement this.

@brettasmi
Copy link
Contributor

brettasmi commented Sep 9, 2021

On our to-dos and will be implemented by relay.

edit: finished for FDA approval

@vgardner-renci can you remove myself, @jenndoug, @suihuang-ISB, and @baranzini-lab? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests