Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Indicate that results are shown because they are subclasses of the input query #117

Closed
sstemann opened this issue Feb 15, 2023 · 7 comments
Assignees
Labels
UI - feature request future enhancement identified by user

Comments

@sstemann
Copy link

Steps:

  1. In the CI UI run query What chemicals may treat Dystonic Disorder: https://ui.ci.transltr.io/results?q=c881b19e-f619-4199-a2db-f9ce8ad5e17b
  2. Notice that some paths do not end in the queried disease. This is by design that results are shown for diseases that are subclasses of the input disease but a user may need something to understand that the specific disease has been expanded upon. Maybe users would get it immediately but logging it for discussion.

image

@sstemann sstemann changed the title Request to Indicate when Results are showing because they are subclasses of the input query Request to Indicate that results are shown because they are subclasses of the input query Feb 15, 2023
@sierra-moxon
Copy link
Member

from TAQA:

  • in the results, we see treatments for many diseases (in this case its a subclass return, which is good and expected, but not transparent to the user)
  • confusing to users, they aren't aware of the hierarchy
  • if the name returned for the disease isn't exactly the one from NodeNormalizer, then we tag the UI with "subclass of" -- just assume it? -- Anne: could just say "related disease" - yep we like that. Matt: it depends on your definition of "related disease"? For the user that wants subclass of. Mike: Indicate subclass of but use different language.

@sierra-moxon
Copy link
Member

@balhoff - can we assume subclass_of for all related diseases? (is this an architecture rule @cbizon?)

@cbizon
Copy link
Collaborator

cbizon commented Feb 17, 2023

In the case that an identifier different from the query identifier is returned in an answer, there should be a query_node_id (or something similar) that specifies which query node that identifier should go with. The only way that should happen is by subclassing, but I do think maybe we should make that explicit, probably using an auxiallry graph @uhbrar @mbrush

@sierra-moxon
Copy link
Member

@uhbrar - do you think this is a use case that is good for auxiliary graphs? :)

@colleenXu
Copy link

colleenXu commented Apr 6, 2023

Note that I added the questions my team has on "ID-expansion" behavior as well as my own impressions and suggestions (not my teams).

My (again, not my teams) short answer is that I'm not enthusiastic about using auxiliary graphs to address this issue.

@sierra-moxon
Copy link
Member

sierra-moxon commented May 5, 2023

from TAQA:
from architecture - we will use aux graphs, but not implement them until after higher priority 1.4 items are implemented. There is enough info in TRAPI atm to implement this in the UI now, but they would need to "redo" it when the aux graph is implemented.

Andy: what is the EPC for the path/graph?
Chris B: one of the reasons the new solution will be helpful (currently no place to put EPC).
Matt: this is called "logical entailment" (pls correct Matt if I got this wrong).
Bill: sometimes these come from SEMMEDDB, not just ontology.

@sierra-moxon sierra-moxon added this to the October - 2023 milestone Jun 1, 2023
@sstemann
Copy link
Author

sstemann commented Feb 9, 2024

subclass of shows in the paths now

@sstemann sstemann closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI - feature request future enhancement identified by user
Projects
None yet
Development

No branches or pull requests

8 participants