Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow units to be defined by bytes #55

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

davidhassell
Copy link
Contributor

Fixes #54

@davidhassell davidhassell added the enhancement New feature or request label Jan 30, 2024
@davidhassell davidhassell added this to the 3.3.7 milestone Jan 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fac74a5) 81.15% compared to head (6bc2bd0) 81.25%.

❗ Current head 6bc2bd0 differs from pull request most recent head 0d0cf7f. Consider uploading reports for the commit 0d0cf7f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   81.15%   81.25%   +0.11%     
==========================================
  Files           2        2              
  Lines         684      688       +4     
==========================================
+ Hits          555      559       +4     
  Misses        129      129              
Flag Coverage Δ
unittests 81.25% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes the fix and +1 for adding a test to cover this in case of a similar bug in future. All good, please merge.

(During reviewing I noticed some unrelated doctest failures, on main as well as this branch, for our test suite, so I'm looking into those and will put up a PR to fix them if they are legit.)

@davidhassell davidhassell merged commit 3dc8980 into NCAS-CMS:main Jan 31, 2024
10 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow units to be defined by bytes
3 participants