LAMA to Dask: _combined_units & further branch tidy
#436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadielbartholomew
added
code tidy
testing
davidhassell
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimately reinstate a commented-out test case, failing due to a minor issue in
_combined_units, which turned out to simply be a use of the propertyData._sizewhich has straightforwardly been replaced byData.size. I also updated all other remaining usage of_sizein the Data module, which turned out to be two extra cases overall.There were in fact two test cases due to be reinstated from the above fix, but one (that concerns
__ipow__) is failing due to data type differences summarised by #435, so I have updated the messages provided by the commented-out case.