Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dask: Data.mean_of_upper_decile #412

Merged
merged 6 commits into from
Jun 22, 2022
Merged

dask: Data.mean_of_upper_decile #412

merged 6 commits into from
Jun 22, 2022

Conversation

davidhassell
Copy link
Collaborator

No description provided.

@davidhassell davidhassell added the dask Relating to the use of Dask label Jun 21, 2022
sadielbartholomew
sadielbartholomew approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about new test warning spam, but otherwise this is all good, so please merge once you feel the comment is addressed.

cf/test/test_Data.py Show resolved Hide resolved
@davidhassell davidhassell mentioned this pull request Jun 22, 2022
Closed
sadielbartholomew
sadielbartholomew approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Item of feedback addressed well and I've sanity checked the overall branch afterwards. Once the merge conflicts are sorted this is good to go. Thanks.

@davidhassell davidhassell merged commit bf6b5f7 into NCAS-CMS:lama-to-dask Jun 22, 2022
@davidhassell davidhassell deleted the dask-mean-of-upper-decile branch November 15, 2022 09:24
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
dask Relating to the use of Dask
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhassell @sadielbartholomew