Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dask: Data.apply_masking #374

Merged
merged 2 commits into from
Apr 12, 2022
Merged

dask: Data.apply_masking #374

merged 2 commits into from
Apr 12, 2022

Conversation

davidhassell
Copy link
Collaborator

No description provided.

@davidhassell davidhassell added the dask Relating to the use of Dask label Apr 5, 2022
@davidhassell davidhassell mentioned this pull request Apr 5, 2022
Closed
sadielbartholomew
sadielbartholomew approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left two suggestions that are unrelated to the core of the PR, but that we may want to include here. All good, though, so please merge at will.

cf/test/test_Data.py Show resolved Hide resolved
cf/data/data.py Show resolved Hide resolved
@sadielbartholomew
Copy link
Member

Thanks for your comments, good to merge now I think!

@davidhassell davidhassell merged commit 0db51e0 into NCAS-CMS:lama-to-dask Apr 12, 2022
@davidhassell davidhassell deleted the dask-apply-masking branch November 15, 2022 09:21
@davidhassell davidhassell added this to the 3.14.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

Assignees
No one assigned
Labels
dask Relating to the use of Dask
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhassell @sadielbartholomew