Remove loops over chunksize in test_Data
#248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadielbartholomew
force-pushed
the
lama-to-dask-5
branch
from
6cb1b9b to
665314c
Compare
|
Opening and closing to re-trigger the CI after I fixed a small issue, squashed the commit down into the previous related one, and force-pushed the branch... |
|
No peer-review necessary since this is a setup/admin PR rather than a method migration and the general principle of removing the explicit chunksize handling in the test was agreed with David in a chat today. CI jobs all pass, so this is good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #182, remove the loop over, and context management of, chunk sizes in
test_Data.Chunk size is a LAMA-related aspect and we can assume (at least until the Data module migration is more complete and we can think about how rigorous this test module needs to be and how to improve it) that the data array memory management is tested thoroughly by Dask so that we don't need to effectively test over a range of sizes of partitions of the sub-arrays.
As a result, three extra tests pass (after being un-skipped) relative to those passing before, since the non-existent attribute of
chunk_sizesbeing called in the test turned out to be the only migration issue left in those small number of cases.