Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMCMAX exceed check fix #111

Merged
merged 1 commit into from
Aug 6, 2018
Merged

SMCMAX exceed check fix #111

merged 1 commit into from
Aug 6, 2018

Conversation

aubreyd
Copy link
Collaborator

@aubreyd aubreyd commented Aug 6, 2018

Reduce smc smcmax check threshold from 10-6 to 10-5 due to some conflicts still triggering at the lower threshold. Need to properly resolve source of small diffs at some point. These seem to result from a small subset of parameter combinations (i.e., during calibration).

…icts triggering at the lower threshold. Need to properly resolve source of small diffs at some point.
@jmccreight jmccreight self-requested a review August 6, 2018 22:52
Copy link
Collaborator

@jmccreight jmccreight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed: Aubrey thinks this is safer than not. She will log an issue about getting to the bottom of this.

@jmccreight jmccreight merged commit 9474111 into NCAR:master Aug 6, 2018
jmccreight pushed a commit to jmccreight/wrf_hydro_nwm_public that referenced this pull request Nov 13, 2018
Testing and travis build updates
laurareads pushed a commit to laurareads/wrf_hydro_nwm_public that referenced this pull request Apr 3, 2019
Add the coupled lesson to internal folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants