Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtc/hwrf-physics: update from support/hafs 2020/06/18 #56

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jun 18, 2020

This PR updates dtc/hwrf-physics with the changes from the support/HAFS branches. The support/HAFS branches contain all updates from the authoritative branches before the FV3 dycore update that was merged on 06/12/2020.

Associated PRs:

#56
NCAR/fv3atm#54
NCAR/ccpp-physics#463

For regression testing information, see below.

lisa-bengtsson and others added 15 commits May 4, 2020 20:03
Updates to cellular automata stochastic physics. Added new regression test. Added possibility to run global and sub-grid CA, updates to coupling to convection.
* Remove unused and unsupported code (See ufs-community#21)
* Remove APPBUILD step from rt.conf
…c-v4 back to master (ufs-community#120)

* Bugfixes for CCPP: check for and correct syntax of \htmlinclude lines
* Fix formatting (tabs, whitespaces) in tests/rt.conf
…te regional tests, ... (ufs-community#126)

* Move ccpp_prebuild from build scripts to CMakeLists.txt
* Add find_package(Python) to CMakeLists.txt
* Update to compile scripts and top-level CMakeLists.txt for not specifying suites for CCPP
* Update of regional tests to reflect changes in suite definition files
* Use cmake 3.16.1 on hera
* Require cmake 3.15 or later in top-level CMakeLists.txt
* Bugfix in tests/fv3_conf/ccpp_regional_run.IN
* Python 3 compatibility for tests/abort_dep_tasks.py

Co-authored-by: Dusan Jovic <[email protected]>
* update orion slurm job card

* udpate orion log files

* update hera log files

Co-authored-by: Jun Wang <[email protected]>
…gi, check for GNU compiler version (ufs-community#139)

* update stampede config, remove cheyenne.pgi config, bugfixes for Python3 on stampede (from @climbfuji)
* check version of GNU compiler ufs-community#134 (from @edwardhartnett)
* submit compile jobs with ecflow to batch system instead of running them on frontend nodes (from @DusanJovic-NOAA)

Co-authored-by: Dusan Jovic <[email protected]>
Co-authored-by: Edward Hartnett <[email protected]>
…with GNU compiler (segmentation fault) (ufs-community#140)

* tests/rt_gnu.conf: turn off IPD tests, no longer working on Cheyenne with GNU compiler (segmentation fault)
* update of jet modulefile and correction of cmake name from jet to jet.intel (to match gnumake)
Changes in this PR:

* add a new regression test that uses the HWRF versions of saSAS deep and shallow convection
* update how the sutils module is loaded on hera and jet
* contains @MinsukJi-NOAA's unit testing branch
* contains @DusanJovic-NOAA's butterfly effect branch (changes in GFDL_atmos_cubed_sphere only)

Note: The changes in the ccpp-physics PR NCAR/ccpp-physics#423 lead to different results for two existing regression tests in PROD mode: fv3_ccpp_regional_c768 and fv3_ccpp_stretched_nest. In a separate comment below, I will describe in detail my investigation that allowed me to conclude that this change is acceptable.

Co-authored-by: MinsukJi-NOAA <[email protected]>
Co-authored-by: Dusan Jovic <[email protected]>
@climbfuji
Copy link
Collaborator Author

Regression testing on hera.intel using rt.conf against "new" baseline, created from official EMC baseline and merging in our previous HWRF baselines. All tests pass.

rt_hera_intel.log

@climbfuji climbfuji marked this pull request as ready for review June 18, 2020 20:28
@climbfuji
Copy link
Collaborator Author

Regression testing on cheyenne.intel using rt_intel.conf: all tests pass except the known problems with run-to-run b4b issues:

fv3_ccpp_regional_c768_HWRF_PBL
fv3_ccpp_regional_c768_FA
fv3_ccpp_regional_c768_FA_HWRF_RRTMG

rt_cheyenne_intel_create.log
rt_cheyenne_intel_verify.log
rt_cheyenne_intel_verify_fail_test.log

@climbfuji
Copy link
Collaborator Author

Regression testing on cheyenne.gnu using rt_gnu.conf: all tests pass (note that the problematic tests for intel are not run for gnu, because they crash right away).
rt_cheyenne_gnu_create.log
rt_cheyenne_gnu_verify.log

@climbfuji climbfuji merged commit c70a57f into NCAR:dtc/hwrf-physics Jun 19, 2020
mzhangw pushed a commit to mzhangw/ufs-weather-model that referenced this pull request Jul 30, 2021
* update with new iau_drymassfixer option
* fix syntax error in fv3
* update fv3_iau test case
* revert iau-drymassfixer change in fv3_gfdlmprad_32bit_post
* update ww3 with bug fix for OpenMp b4b
* update fv3 with coupled model dump field changes
* update nemscompset run c768 fv3-ww3 to use threads
* update NEMS to the latest version
* update post lib to 8.0.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants