Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtc/hwrf-physics: HWRF Ferrier-Aligo MP scheme updates #41

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Apr 14, 2020

This PR replaces #25, which was for target branch dtc/develop. Only one commit was required and cherry-picked from this PR, namely fa355b9. Additional updates are made to tests/rt.conf to reflect the change of the regression test name from this commit.

Associated PRs:

NCAR/ccpp-physics#435
NCAR/fv3atm#43
#41

For regression testing information, see below.

@climbfuji
Copy link
Collaborator Author

climbfuji commented Apr 14, 2020

Regression testing on hera.intel:

  1. Copied the existing baseline with date tag 20200410 to the new date tag 20200415

  2. Ran only the tests that use the Ferrier-Aligo scheme, these were expected to fail (and they did in REPRO and PROD mode):

fv3_ccpp_regional_c768_FA
fv3_ccpp_regional_c768_HWRF_PBL
fv3_ccpp_regional_c768_FA_HWRF_RRTMG

rt_hera_intel_fa_only_against_old_baseline.log
rt_hera_intel_fa_only_against_old_baseline_fail_test.log

  1. Created new baseline results for these tests only - all runs completed successfully

rt_hera_intel_fa_only_create.log

  1. Update the 20200415 baseline with these results.

  2. Run full regression test suite (rt.conf ) against the 20200415 baseline: all tests pass.

rt_hera_intel_against_20200415_baseline.log

…SDF name change FV3_HAFS_ferhires_update_moist -> FV3_HAFS_ferhires, new rt_intel.conf for Cheyenne, additional tests in rt_gnu.conf
@climbfuji
Copy link
Collaborator Author

climbfuji commented Apr 15, 2020

Regression testing on cheyenne.{gnu,intel}: no baseline exists thus far.

  1. Copied the baseline input directories from hera to cheyenne, updated rt_gnu.conf to include the HWRF regression tests, and created a new rt_intel.conf for cheyenne only (we have kept the cheyenne.intel tests separate in rt_intel.conf in dtc/develop as well, because rt.conf is maintained by EMC and they cannot test on and thus do not care about cheyenne).

  2. Testing shows that the FA tests either run out of time or crash with the GNU compiler, hence turned them off again in rt_gnu.conf for this commit.

  3. Creating a new baseline using rt_gnu.conf and rt_intel.conf: all tests completed.

rt_cheyenne_gnu_create.log
rt_cheyenne_intel_create.log

  1. Copy the newly created baselines into the final location, then rerun full tests against it: GNU: all tests pass, Intel: problems with reproducibility from run to run in both REPRO and PROD mode - see issue dtc/hwrf-physics: issues with Ferrier-Aligo updates ccpp-physics#438.

rt_cheyenne_gnu_verify.log

@ligiabernardet
Copy link
Collaborator

Looks good to me, I left some comments wrt SciDoc in the ccpp-physics PR.

@climbfuji climbfuji merged commit 9530f06 into NCAR:dtc/hwrf-physics Apr 16, 2020
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Nov 10, 2020
…elop_20200903

Update gsd/develop from develop 2020/10/01
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Mar 16, 2023
…le pointer update for ufs-community#462 (ufs-community#1654)

* update FV3 submodule and .gitmodules for testing of 20230313_combo

* turn off cpld_control_p8_faster cheyenne
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants