Address performance and deprecations in interp_hybrid_to_pressure #592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Refactors the helper function
_vertical_remap_extrap
to avoid problematic for loops over the vertical levels and addresses some warnings related to specification of chunks, dimension specification withargmax
, and intentional interpolation out of bounds.While this seems to address the most significant issues in terms of performance / execution time, there's still some clean up to be done in
interp_hybrid_to_pressure
and it would be nice to have a benchmark to cover this.I did also replicate the poor performance with a larger example on my laptop in addition to the HPC system.
Closes #591
PR Checklist
General
closes #XXX
to the PR description where XXX is the number of the issue.docs/release-notes.rst
in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecatedprecommit
. To set up on your local, runpre-commit install
from the top level of the repository. To manually run pre-commits, usepre-commit run --all-files
and re-add any changed files before committing again and pushing.