Add tests for ccpp_prebuild step #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
October 11, 2022 19:43
dustinswales
requested review from
climbfuji,
SamuelTrahanNOAA,
grantfirl,
mzhangw,
panll,
mkavulich and
ChunxiZhang-NOAA
as code owners
dustinswales
removed request for
climbfuji,
mkavulich,
panll,
mzhangw,
SamuelTrahanNOAA and
ChunxiZhang-NOAA
added 2 commits
October 12, 2022 10:45
|
Did you mean all available host models, currently NCAR/ccpp-scm and NOAA-EMC/fv3atm? That is, the tests work for the CCPP Single Column Model and the UFS atmospheric model component (fv3atm)? |
|
@grantfirl We discussed going ahead with adding these tests today. Can you provide a review? (no rush) |
grantfirl
reviewed
Oct 27, 2022
| run: | | ||
| cd /home/runner/work/ccpp-physics/ccpp-physics/fv3atm/ccpp/ | ||
| mkdir -p /home/runner/work/ccpp-physics/ccpp-physics/fv3atm/bin/ccpp/physics/physics/ | ||
| ./framework/scripts/ccpp_prebuild.py --config config/ccpp_prebuild_config.py |
There was a problem hiding this comment.
For the first pass at this, I don't see a problem with parsing all suites, but we may want to define a shorter list to parse at some point to make these tests run faster?
There was a problem hiding this comment.
That sounds like a good idea. I'll add a note for us to discuss this.
grantfirl
approved these changes
Oct 27, 2022
This was referenced Nov 17, 2022
ChunxiZhang-NOAA
added a commit
to ufs-community/ccpp-physics
that referenced
this pull request
Nov 21, 2022
NCAR/main PR NCAR#972
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds continuous integration tests to run the ccpp_prebuild script for all available host models, currently NCAR/ccpp-scm and NOAA-EMC/fv3atm.
For each host-model, the scripts do the following:
This is done for all commits and PRs.