-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgraded OPAC aerosol with more advanced MERRA2 aerosol #594
Conversation
create a new pull request because my old one is in my own fork and cannot be seen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions, no real concerns. Is this PR up to date with the current code? It looks like at the moment. However the submodule pointer in the FV3 PR NOAA-EMC/fv3atm#254 (review) shows an update of submodule rte-rrtmgp, which this PR here doesn't. Probably the FV3 PR isn't up to date with your own changes (and also not with the authoritative repository).
Dom:
Iamin, iamax, jamin, and jamax are all local variables, needing to
calculate only once, and to be saved for the following steps.
I have delete the extra whitespaces in physics/aerinterp.F90
<#594 (comment)>.
Anning
…On Mon, Mar 15, 2021 at 5:50 PM Dom Heinzeller ***@***.***> wrote:
***@***.**** commented on this pull request.
Just a few questions, no real concerns. Is this PR up to date with the
current code? It looks like at the moment. However the submodule pointer in
the FV3 PR NOAA-EMC/fv3atm#254 (review)
<NOAA-EMC/fv3atm#254 (review)>
shows an update of submodule rte-rrtmgp, which this PR here doesn't.
Probably the FV3 PR isn't up to date with your own changes (and also not
with the authoritative repository).
------------------------------
In physics/GFS_phys_time_vary.fv3.F90
<#594 (comment)>:
> @@ -182,12 +182,17 @@ subroutine GFS_phys_time_vary_init (
errflg = 0
if (is_initialized) return
+ iamin=999
Why is this required? Because they are local variables?
------------------------------
In physics/aerinterp.F90
<#594 (comment)>:
> @@ -341,7 +339,7 @@ SUBROUTINE aerinterpol(me,master,npts,IDATE,FHOUR,jindx1,jindx2, &
+TEMI*DDY(j)*aer_pres(I1,J2,L,n1)+DDX(j)*TEMJ*aer_pres(I2,J1,L,n1))&
+tx2*(TEMI*TEMJ*aer_pres(I1,J1,L,n2)+DDX(j)*DDY(J)*aer_pres(I2,J2,L,n2) &
+TEMI*DDY(j)*aer_pres(I1,J2,L,n2)+DDX(j)*TEMJ*aer_pres(I2,J1,L,n2))
-
+
Please remove these extra whitespaces
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#594 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIMDQS5AC3I26OZ52W3TDZ6I5ANCNFSM4ZCQU3PA>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks for making the changes. Will approve when it is time for the commit to go in (and everything is up to date again - there will be commits going in before you).
@@ -367,6 +376,10 @@ subroutine GFS_phys_time_vary_init ( | |||
!$OMP end sections | |||
|
|||
!$OMP end parallel | |||
if (iaerclm) then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is ok to leave it here for the moment, given that I will be working on speeding up the code in physics/GFS_phys_time_vary.fv3.F90
after your commit went in.
* upstream/master: change declaration of dtdtnp in GFS_stochastics Address Dom code review Turn on mass flux diagnostics updating RAS with some minor modifications fixing radsw_main updating MGx routines and SW main for some potential issues and fixes adding updated RAS point to correct branch of rrtmgp add MP perturbations to ca_global section add ca_global to radiation tendency logic add cloud perturbations and clean up radiation perturbations merge with upstream NCAR add temporary surface perturbation diagnostic additions for MP perturbations add CN perts to GFS_stochastics add mp perts to GFS_stochastics
* Add a new SDF named FV3_WoFS_v0 for SRW_v2.1 release * Minor bug fix to add variable nf_albd in the host model data structure (CCPP_typedefs.F90)
MERRA2 ten year climatology data has been longitude flipped offline from -180 to 180 to 0 to 360 degree in order to decrease the computation cost.
MERRA2 interpolation code has been overhauled and the memory usage has been decreased 96 times (96 processors) for C768L127 with MERRA2 72 levels data.