Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure travis for basic encoding checks, and saturation adjustment check for number of water species #451

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented May 11, 2020

This PR:

  • physics/gfdl_fv_sat_adj.F90: add compatibility check for six water species
  • add GitHub workflow for basic checks, add tool to check for ASCII encoding of Fortran source files and metadata files
  • fix non-ascii characters in comments in a bunch of files

Associated PRs:
NOAA-EMC/GFDL_atmos_cubed_sphere#20
NCAR/ccpp-framework#292
#451
NOAA-EMC/fv3atm#115
NOAA-EMC/NEMS#62
ufs-community/ufs-weather-model#126

For regression testing information, see ufs-community/ufs-weather-model#126.

@climbfuji climbfuji marked this pull request as ready for review May 12, 2020 13:39
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link
Contributor

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@climbfuji climbfuji merged commit 66376d5 into NCAR:master May 12, 2020
@climbfuji climbfuji deleted the travis-encoding-check_and_saturation-adjustment-check branch June 27, 2022 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants