Bring documentation updates from release/public-v4 back to master, correct syntax of \htmlinclude line for m_micro_run #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional xml files for GFSv15p2 and GFSv16beta
…cean scientific documentation
* scientific documentation update for UFS public release, add two additional xml files for GFSv15p2 and GFSv16beta * add two new suites: GFSv15p2_no_nsst and GFSv16beta_no_nsst and GFS ocean scientific documentation
Co-Authored-By: ligiabernardet <[email protected]>
|
@ligiabernardet @mzhangw @JulieSchramm I created a PR to bring back the updates (almost exclusively scientific documentation) from the public release to master. Please check everything carefully, as there were many merge conflicts and changes made in both branches. Let me know if you find anything wrong. Once this PR is part of the entire ufs-weather-model "bring hotfixes from public release back to master / develop", you can also generate the scientific documentation and look at the output. Thanks! |
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
llpcarson
approved these changes
May 7, 2020
|
Looks good to me.
…On Thu, May 7, 2020 at 10:11 AM Laurie Carson ***@***.***> wrote:
***@***.**** approved this pull request.
approved, pending reg-tests with the other PRs/repos
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#448 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE7WQAU3LOGYKX7ZTVOQIH3RQLMTDANCNFSM4M2R3QJQ>
.
|
|
This PR and NCAR/ccpp-framework#289 will have to wait for the next round. When merging them (together with my fv3atm changes) into Dusan's branch, some of the new csawmg tests failed. We postponed this until next week when I am 100% back to work. |
climbfuji
changed the title
climbfuji
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
physics/m_micro.F90: correct syntax for\htmlincludeline for schemem_micro_run; @mzhangw @ligiabernardet @JulieSchramm: during the update of the scientific documentation, someone replaced the correct syntaxwith
and the CCPP framework didn't check for this error. As a result,
m_micro_runhad an empty CCPP argument table and was removed entirely. PR NCAR/ccpp-framework#289 adds the missing check in the metadata parser script.Associated PRs:
NCAR/ccpp-framework#289
#448
NOAA-EMC/fv3atm#113
ufs-community/ufs-weather-model#120
For regression testing information, see ufs-community/ufs-weather-model#120.