Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up changes for PR https://github.com/NCAR/ccpp-framework/pull/307 #309

Closed
climbfuji opened this issue Jul 1, 2020 · 1 comment
Assignees
Labels
ccpp_prebuild bugs, requests, etc. that involve ccpp_prebuild

Comments

@climbfuji
Copy link
Collaborator

The following changes were suggested during the code review of PR #307.

scripts/ccpp_prebuild.py, line 381

-                if type(optional_arguments[module_name][subroutine_name]) is list:
+                if isinstance(optional_arguments[module_name][subroutine_name], list):

scripts/conversion_tools/unit_conversion.py, line 116

-    return '{var}/1.0E+3{kind}'
+    return '{var}*1.0E-3{kind}'

scripts/mkcap.py, line 94

-        if not type(value) is list:
+        if not isinstance(value, list):

scripts/mkcap.py, line 173

-        if type(values)==dict:
+        if isinstance(values, dict):
@climbfuji climbfuji self-assigned this Jul 1, 2020
@climbfuji climbfuji added the ccpp_prebuild bugs, requests, etc. that involve ccpp_prebuild label Jul 1, 2020
climbfuji added a commit that referenced this issue Jul 15, 2020
Add unit conversion from degrees to radians, address isssue #309
@climbfuji
Copy link
Collaborator Author

Fixed in #311.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ccpp_prebuild bugs, requests, etc. that involve ccpp_prebuild
Projects
None yet
Development

No branches or pull requests

1 participant