Small fixes #313
Merged
Small fixes #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-richling
added
code clean-up
nusbaume
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Looks good, just two (optional) change requests. Thanks @justin-richling!
config_amwg_default_plots.yaml
Outdated
| @@ -291,7 +291,7 @@ diag_cvdp_info: | |||
| cvdp_codebase_loc: /glade/u/home/asphilli/CESM-diagnostics/CVDP/Release/v5.2.0/ | |||
|
|
|||
| # Location where cvdp codebase will be copied to and diagnostic plots will be stored | |||
| cvdp_loc: /glade/scratch/asphilli/ADF-Sandbox/cvdp/ #MUST EDIT! | |||
| cvdp_loc: /glade/derecho/scratch/asphilli/ADF-Sandbox/cvdp/ #MUST EDIT! | |||
There was a problem hiding this comment.
Should we change this path to automatically output to the user's scratch? For example:
Suggested change
| cvdp_loc: /glade/derecho/scratch/asphilli/ADF-Sandbox/cvdp/ #MUST EDIT! | |
| cvdp_loc: /glade/derecho/scratch/${user}/ADF/cvdp/ |
config_cam_baseline_example.yaml
Outdated
| @@ -376,7 +376,7 @@ diag_cvdp_info: | |||
| cvdp_codebase_loc: /glade/u/home/asphilli/CESM-diagnostics/CVDP/Release/v5.2.0/ | |||
|
|
|||
| # Location where cvdp codebase will be copied to and diagnostic plots will be stored | |||
| cvdp_loc: /glade/scratch/asphilli/ADF-Sandbox/cvdp/ #MUST EDIT! | |||
| cvdp_loc: /glade/derecho/scratch/asphilli/ADF-Sandbox/cvdp/ #MUST EDIT! | |||
There was a problem hiding this comment.
Should we change this path to automatically output to the user's scratch? For example:
Suggested change
| cvdp_loc: /glade/derecho/scratch/asphilli/ADF-Sandbox/cvdp/ #MUST EDIT! | |
| cvdp_loc: /glade/derecho/scratch/${user}/ADF/cvdp/ |
There was a problem hiding this comment.
Good thinking, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the config yaml files for updated example CAM cases and history files.
There are now 4 example coupled cases in:
/glade/campaign/cgd/amp/amwg/ADF_test_cases:- 3 recent cases with h0a history files
- 1 semi-recent case with old h0 history files
Each with 10 years of data
Additionally, update paths for Derecho scratch locations and update
hist_strargument to default tocam.h0a.In
tape_recorder.py, add check for scenario where no test case data is available and exit script if so.Closes #289