Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header bug in html webpages #274

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

justin-richling
Copy link
Collaborator

Climo years in the webpage header were being based off config file declared years. This will take it from the curated climo years done in adf_info.py.

This also fixes the bug that shows up when viewing the tables page where both test and baseline cases in html header display the same case name.

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Just one minor request.

lib/adf_web.py Outdated
Comment on lines 358 to 359
syear_baseline = ""
eyear_baseline = ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these lines are needed, as I believe the climo_yrs method will return empty strings for the baseline case automatically if compare_obs is True.

@justin-richling justin-richling merged commit fe04d98 into NCAR:main Jan 11, 2024
7 checks passed
@justin-richling justin-richling deleted the website-header-fix branch January 11, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants