-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
making annual mean plots display by default. #270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that with this change we no longer need the "no-plot" variable landing page represented by template_var.html
. Thus my vote would be to go ahead and delete template_var.html
and the associated code in adf_web.py
, which I believe are just lines 666 to 688, in this same PR. What are your thoughts @justin-richling and @brianpm?
@nusbaume Yeah I don't see that being an issue if the |
@justin-richling good catch! We'll need some way to handle "special" seasons before this PR can be merged. Happy to look over your fix whenever it is ready. Otherwise I think I have a couple ideas myself that we can discuss if need be. |
This will introduce a change into the web objects for kwarg `non_season` that will flag a plot type if it doesn't have traditional seasons, like the QBO. For these types of plots, it will default to the first "season", for QBO this will be TimeSeries.
Update websites to display plots by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me now. Thanks @bstephens82 and @justin-richling!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks all!
No description provided.