Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making annual mean plots display by default. #270

Merged
merged 7 commits into from
Jan 22, 2024

Conversation

bstephens82
Copy link
Contributor

No description provided.

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that with this change we no longer need the "no-plot" variable landing page represented by template_var.html. Thus my vote would be to go ahead and delete template_var.html and the associated code in adf_web.py, which I believe are just lines 666 to 688, in this same PR. What are your thoughts @justin-richling and @brianpm?

@nusbaume nusbaume added the website Having to do with the generated website label Dec 26, 2023
@justin-richling
Copy link
Collaborator

@nusbaume Yeah I don't see that being an issue if the template_var.html file is literally just a place holder page. The only issue I can see with this is that for the QBO the "seasons" are the time series and amplitude plots. I have an idea that I was working on in a different branch that might help

@nusbaume
Copy link
Collaborator

nusbaume commented Jan 3, 2024

@justin-richling good catch! We'll need some way to handle "special" seasons before this PR can be merged. Happy to look over your fix whenever it is ready. Otherwise I think I have a couple ideas myself that we can discuss if need be.

justin-richling and others added 6 commits January 9, 2024 11:35
This will introduce a change into the web objects for kwarg `non_season` that will flag a plot type if it doesn't have traditional seasons, like the QBO.

For these types of plots, it will default to the first "season", for QBO this will be TimeSeries.
Update websites to display plots by default
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me now. Thanks @bstephens82 and @justin-richling!

Copy link
Collaborator

@justin-richling justin-richling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks all!

@justin-richling justin-richling merged commit 5888958 into NCAR:main Jan 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Having to do with the generated website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants