Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard navigation on absence page + edit dialog #666

Open
3 tasks
ghost opened this issue Sep 22, 2022 · 0 comments
Open
3 tasks

Keyboard navigation on absence page + edit dialog #666

ghost opened this issue Sep 22, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Sep 22, 2022

Describe the bug

Keyboard navigation is now (commit b1bc538) possible to use for adding and deleting absence, but the behaviour is very inconsistent. The edit dialog does not work using keyboard navigation and behaves in a very confusing way when you try to use it - i.e. it opens with focus on the cancel button and if you press tab focus moves outside the dialog. To reach a date field you have to "tab backwards". The Esc key does not work properly (seems to be depending on focus).

Other accessibility issues are:

  1. Empty header (

    )
  2. Empty button () x 2
  3. No label for form control (
    ) x 2

Expected behavior

  • The tab order and possible shift of focus should be logic and consistent.
  • Editing absence should be using the same page and controls as adding absence, not popup a new (different) dialog with a different way of working.
  • Testing accessibility with WebAIM should result in no errors.

Additional context

Compare to #295, #350, #454

@ghost ghost added the bug Something isn't working label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants