-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimally handle SEED files and fix automated test caching issue #1057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to do mvn clean package
but I got:
[ERROR] Tests run: 269, Failures: 101, Errors: 0, Skipped: 23
Is there an external dependency I need to update?
Nope. It is simply broken. I have a really good case where the injection of schematron at test 1 is causing an error in test 8 because it thinks the model version should match the injected schematron. Maybe I can figure out what cache is not being emptied now. |
@al-niessner oh okay, no problem! Thanks for letting me know! |
1. changed stepdefs so that internal errors cannot be overlooked. Turns out there are 9 of them. 2. commented out the offending 9 tests with internal and marked them with FIXME 1058 allowing them to be scheduled at a later time. They are complex errors and well beyond the scope of this issue
@jordanpadams @nutjob4life @tloubrieu-jpl It is ready for release. The tests now all run on my laptop successfully. Waiting for github actions but my expectation is that they will pass. Two important things beyond this actual ticket:
|
@al-niessner this is very exciting! Great work! This mole has roamed free for many years. He must be the mole from Caddyshack. He has been harassing Bill Murray for too long... |
@jordanpadams is too fast; I only just now got:
Anyway, wooooot! 🎉 |
🗒️ Summary
Added to allowable mime types and how that maps to extensions.
⚙️ Test Data and/or Report
All unit tests below should pass but specifically 1028
♻️ Related Issues
Closes #1028