Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimally handle SEED files and fix automated test caching issue #1057

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

Added to allowable mime types and how that maps to extensions.

⚙️ Test Data and/or Report

All unit tests below should pass but specifically 1028

♻️ Related Issues

Closes #1028

@al-niessner al-niessner self-assigned this Nov 6, 2024
@al-niessner al-niessner requested a review from a team as a code owner November 6, 2024 18:22
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to do mvn clean package but I got:

[ERROR] Tests run: 269, Failures: 101, Errors: 0, Skipped: 23

Is there an external dependency I need to update?

@al-niessner al-niessner marked this pull request as draft November 6, 2024 19:07
@al-niessner
Copy link
Contributor Author

@nutjob4life

Nope. It is simply broken. I have a really good case where the injection of schematron at test 1 is causing an error in test 8 because it thinks the model version should match the injected schematron. Maybe I can figure out what cache is not being emptied now.

@nutjob4life
Copy link
Member

@al-niessner oh okay, no problem! Thanks for letting me know!

Al Niessner added 3 commits November 6, 2024 18:02
1. changed stepdefs so that internal errors cannot be overlooked. Turns out there are 9 of them.
2. commented out the offending 9 tests with internal and marked them with FIXME 1058 allowing them to be scheduled at a later time. They are complex errors and well beyond the scope of this issue
@al-niessner al-niessner marked this pull request as ready for review November 7, 2024 18:19
@al-niessner
Copy link
Contributor Author

@jordanpadams @nutjob4life @tloubrieu-jpl

It is ready for release. The tests now all run on my laptop successfully. Waiting for github actions but my expectation is that they will pass. Two important things beyond this actual ticket:

  1. The schema(tron) caches are now cleared. Using this ticket, I was able to uncover the mole sequestering the hidden caches.
  2. Will now always fail on internal error. Well it works well for surprises, we should not accept surprises in our regression testing. Turns out that 9 tests were/are failing because it is generating internal errors when it should not be. Marked them and created validate cucumber testing is not exercising all tests as it should be #1058 so that y'all can schedule when you want to fix them. They are not trivial.

@jordanpadams
Copy link
Member

The schema(tron) caches are now cleared. Using this ticket, I was able to uncover the mole sequestering the hidden caches.

@al-niessner this is very exciting! Great work! This mole has roamed free for many years. He must be the mole from Caddyshack. He has been harassing Bill Murray for too long...

@jordanpadams jordanpadams changed the title Issue 1028: minimally handle seed files Minimally handle seed files and fix automated test caching issue Nov 7, 2024
@jordanpadams jordanpadams changed the title Minimally handle seed files and fix automated test caching issue Minimally handle SEED files and fix automated test caching issue Nov 7, 2024
@jordanpadams jordanpadams merged commit 8eb5c52 into main Nov 7, 2024
3 checks passed
@jordanpadams jordanpadams deleted the issue_1028 branch November 7, 2024 18:44
@nutjob4life
Copy link
Member

@jordanpadams is too fast; I only just now got:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

Anyway, wooooot! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate incorrectly disallows Encoded_Native/encoding_standard_id = 'SEED 2.4'
3 participants