-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-arrange the folders, and add peppi to the Galileo notebook #80
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on visual inspection only—trust accordingly
(brew install gdal
also install llvm
which is a 2GB (👀) dependency!)
WAIT A SEC … I think there's an error in requirements.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be an error in requirements.txt
:
$ pip install --requirement requirements.txt
ERROR: Invalid requirement: 'requires gdal > 3.8, install on macos with brew install gdal': Expected end or semicolon (after name and no valid version specifier)
requires gdal > 3.8, install on macos with brew install gdal
^ (from line 20 of requirements.txt)
Thanks for catching the error on the requirements.txt file @nutjob4life . I fixed that and some other errors that I noticed yesterday while demoing the notebook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tloubrieu-jpl thanks!
I think you might want to add .spice_kernels/
to .gitignore
.
I can't get this notebook GLL_MagPlot.ipynb
to run, though:
File ~/Documents/Clients/JPL/PDS/Development/nasa-pds/search-api-notebook/.venv/lib/python3.9/site-packages/pds4_tools/viewer/core.py:21
18 from ..utils.logging import logger_init
20 from ..extern import six
---> 21 from ..extern.six.moves.tkinter import Event as TKEvent
22 from ..extern.six.moves.tkinter import (Tk, Toplevel, PhotoImage, Menu, Scrollbar, Canvas, Frame, Label,
23 Entry, Text, Button, Checkbutton, BooleanVar, StringVar, TclError)
25 # NOTE: DO NOT IMPORT MATPLOTLIB HERE, or import any other module
26 # that in-turn imports MPL or any module that imports anything that
27 # should not be imported when the Viewer is not actually used. See
(...)
31
32 # Initialize the logger
File ~/Documents/Clients/JPL/PDS/Development/nasa-pds/search-api-notebook/.venv/lib/python3.9/site-packages/pds4_tools/extern/six.py:203, in _SixMetaPathImporter.load_module(self, fullname)
201 mod = self.__get_module(fullname)
202 if isinstance(mod, MovedModule):
--> 203 mod = mod._resolve()
204 else:
205 mod.__loader__ = self
File ~/Documents/Clients/JPL/PDS/Development/nasa-pds/search-api-notebook/.venv/lib/python3.9/site-packages/pds4_tools/extern/six.py:115, in MovedModule._resolve(self)
114 def _resolve(self):
--> 115 return _import_module(self.mod)
File ~/Documents/Clients/JPL/PDS/Development/nasa-pds/search-api-notebook/.venv/lib/python3.9/site-packages/pds4_tools/extern/six.py:82, in _import_module(name)
80 def _import_module(name):
81 """Import module, returning the module after the last dot."""
---> 82 __import__(name)
83 return sys.modules[name]
File /opt/homebrew/Cellar/[email protected]/3.9.20/Frameworks/Python.framework/Versions/3.9/lib/python3.9/tkinter/__init__.py:37
34 import sys
35 import types
---> 37 import _tkinter # If this fails your Python may not be configured for Tk
38 TclError = _tkinter.TclError
39 from tkinter.constants import *
ModuleNotFoundError: No module named '_tkinter'
I must doing something wrong—but will have to investigate further later on
@nutjob4life I get the same error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GLL notebook doesn't work. See earlier comments
Ok thanks for the feedback, I ll investigate that from a fresh virtual environment.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Jordan Padams ***@***.***>
Sent: Monday, December 9, 2024 6:00:45 PM
To: NASA-PDS/search-api-notebook ***@***.***>
Cc: Loubrieu, Thomas G (US 398F) ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] Re: [NASA-PDS/search-api-notebook] Re-arrange the folders, and add peppi to the Galileo notebook (PR #80)
@jordanpadams requested changes on this pull request.
GLL notebook doesn't work. See earlier comments
—
Reply to this email directly, view it on GitHub<https://urldefense.us/v3/__https://github.com/NASA-PDS/search-api-notebook/pull/80*pullrequestreview-2490303970__;Iw!!PvBDto6Hs4WbVuu7!I19_-Xp28QYDvW4_x3_DSJPP3IUiZJ0qJfkprXfR2r0Gk66piN5VHetrzCkBY3H9bZpOWq_tmn4LeSKr7iDVrz5L3Bb54hkmDL8N$>, or unsubscribe<https://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/AORLCUHY2U57XHWQTCGEKCL2EYOJ3AVCNFSM6AAAAABTGYNUG2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOJQGMYDGOJXGA__;!!PvBDto6Hs4WbVuu7!I19_-Xp28QYDvW4_x3_DSJPP3IUiZJ0qJfkprXfR2r0Gk66piN5VHetrzCkBY3H9bZpOWq_tmn4LeSKr7iDVrz5L3Bb54kgSFPop$>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@nutjob4life @jordanpadams , regarding the I am wondering if that would solve your issue. |
@tloubrieu-jpl thanks for pointing that out. I totally missed those instructions (I saw "at this point, you'll have a locally running…" and assumed I was ready to try it out). However, even after running the two I vaguely recall from experience that |
@tloubrieu-jpl okay, doing The next error is |
@nutjob4life commented out. merging. |
@jordanpadams thanks much! |
🗒️ Summary
Add peppi to the Galileo notebook.
Organize all the notebook into their respective discipline node.