Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-arrange the folders, and add peppi to the Galileo notebook #80

Merged
merged 10 commits into from
Dec 31, 2024

Conversation

tloubrieu-jpl
Copy link
Member

🗒️ Summary

Add peppi to the Galileo notebook.
Organize all the notebook into their respective discipline node.

@tloubrieu-jpl tloubrieu-jpl requested a review from a team as a code owner December 8, 2024 02:29
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on visual inspection only—trust accordingly

(brew install gdal also install llvm which is a 2GB (👀) dependency!)

WAIT A SEC … I think there's an error in requirements.txt

@nutjob4life nutjob4life self-requested a review December 8, 2024 21:25
Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be an error in requirements.txt:

$ pip install --requirement requirements.txt
ERROR: Invalid requirement: 'requires gdal > 3.8, install on macos with brew install gdal': Expected end or semicolon (after name and no valid version specifier)
    requires gdal > 3.8, install on macos with brew install gdal
             ^ (from line 20 of requirements.txt)

@tloubrieu-jpl
Copy link
Member Author

Thanks for catching the error on the requirements.txt file @nutjob4life . I fixed that and some other errors that I noticed yesterday while demoing the notebook.

Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tloubrieu-jpl thanks!

I think you might want to add .spice_kernels/ to .gitignore.

I can't get this notebook GLL_MagPlot.ipynb to run, though:

File ~/Documents/Clients/JPL/PDS/Development/nasa-pds/search-api-notebook/.venv/lib/python3.9/site-packages/pds4_tools/viewer/core.py:21
     18 from ..utils.logging import logger_init
     20 from ..extern import six
---> 21 from ..extern.six.moves.tkinter import Event as TKEvent
     22 from ..extern.six.moves.tkinter import (Tk, Toplevel, PhotoImage, Menu, Scrollbar, Canvas, Frame, Label,
     23                                         Entry, Text, Button, Checkbutton, BooleanVar, StringVar, TclError)
     25 # NOTE: DO NOT IMPORT MATPLOTLIB HERE, or import any other module
     26 # that in-turn imports MPL or any module that imports anything that
     27 # should not be imported when the Viewer is not actually used. See
   (...)
     31 
     32 # Initialize the logger

File ~/Documents/Clients/JPL/PDS/Development/nasa-pds/search-api-notebook/.venv/lib/python3.9/site-packages/pds4_tools/extern/six.py:203, in _SixMetaPathImporter.load_module(self, fullname)
    201 mod = self.__get_module(fullname)
    202 if isinstance(mod, MovedModule):
--> 203     mod = mod._resolve()
    204 else:
    205     mod.__loader__ = self

File ~/Documents/Clients/JPL/PDS/Development/nasa-pds/search-api-notebook/.venv/lib/python3.9/site-packages/pds4_tools/extern/six.py:115, in MovedModule._resolve(self)
    114 def _resolve(self):
--> 115     return _import_module(self.mod)

File ~/Documents/Clients/JPL/PDS/Development/nasa-pds/search-api-notebook/.venv/lib/python3.9/site-packages/pds4_tools/extern/six.py:82, in _import_module(name)
     80 def _import_module(name):
     81     """Import module, returning the module after the last dot."""
---> 82     __import__(name)
     83     return sys.modules[name]

File /opt/homebrew/Cellar/[email protected]/3.9.20/Frameworks/Python.framework/Versions/3.9/lib/python3.9/tkinter/__init__.py:37
     34 import sys
     35 import types
---> 37 import _tkinter # If this fails your Python may not be configured for Tk
     38 TclError = _tkinter.TclError
     39 from tkinter.constants import *

ModuleNotFoundError: No module named '_tkinter'

I must doing something wrong—but will have to investigate further later on

@jordanpadams
Copy link
Member

@nutjob4life I get the same error

Copy link
Member

@jordanpadams jordanpadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GLL notebook doesn't work. See earlier comments

@tloubrieu-jpl
Copy link
Member Author

tloubrieu-jpl commented Dec 9, 2024 via email

@tloubrieu-jpl
Copy link
Member Author

@nutjob4life @jordanpadams , regarding the tinker import error, did you follow this step from the README ?
image

I am wondering if that would solve your issue.

@nutjob4life
Copy link
Member

@tloubrieu-jpl thanks for pointing that out. I totally missed those instructions (I saw "at this point, you'll have a locally running…" and assumed I was ready to try it out).

However, even after running the two labextension install commands and the lab build command—and opening up the AAS WorldWide Telescope tab—I still get the _tkinter error when running the notebook.

I vaguely recall from experience that _tkinter is Python's Tcl/Tk integration for UI elements. I'm going to try to brew install python-tk to see if that helps. Do you have python-tk installed?

@nutjob4life
Copy link
Member

@tloubrieu-jpl okay, doing brew install python-tk@VERSION got it past the _tkinter error.

The next error is NameError: name 'eph' is not defined, but that's under the "work in progress" heading so I'm not concerned about that. Maybe we should comment-out that whole section just to prevent end-users from seeing red?

@jordanpadams
Copy link
Member

@nutjob4life commented out. merging.

@jordanpadams jordanpadams merged commit b5d29bb into main Dec 31, 2024
@jordanpadams jordanpadams deleted the reorg branch December 31, 2024 18:23
@nutjob4life
Copy link
Member

@jordanpadams thanks much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants