Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate elasticsearch client to opensearch-py for legacy synx sweeper… #80

Merged
merged 1 commit into from
Oct 9, 2023
Merged

migrate elasticsearch client to opensearch-py for legacy synx sweeper… #80

merged 1 commit into from
Oct 9, 2023

Conversation

tloubrieu-jpl
Copy link
Member

@tloubrieu-jpl tloubrieu-jpl commented Oct 9, 2023 •
edited
Loading

…. And use a temporary pypi package as a dependency.

🗒️ Summary

  1. The migration to using opensearch-py as a client (Use opensearchPy instead of direct opensearch API requests #72). was not done for the legacy Solr synchronization sweeper. It is now done.
  2. Also, one depency was girectly on a github repository (solr-to-es) which is not allowed by pypi. So I published the dependency myself (while waiting for this ticket to be resolved Release an updated package on pypi o19s/solr-to-es#23). And I used this dependency in the current project.

migrate elasticsearch client to opensearch-py for legacy synx sweeper…
a1a9878 
…. Use pypi temporary release of a dependency.
alexdunnjpl
alexdunnjpl approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@alexdunnjpl alexdunnjpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tloubrieu-jpl tloubrieu-jpl merged commit 4ef7ed8 into main Oct 9, 2023
1 check passed
@tloubrieu-jpl tloubrieu-jpl deleted the legacy_opensearch branch October 9, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdunnjpl alexdunnjpl alexdunnjpl approved these changes

@nutjob4life nutjob4life Awaiting requested review from nutjob4life nutjob4life is a code owner

@collinss-jpl collinss-jpl Awaiting requested review from collinss-jpl collinss-jpl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release an updated package on pypi
2 participants
@tloubrieu-jpl @alexdunnjpl