Implement sweeper data versioning for repairkit #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this avoids redundant processing and should make the sweeper "free" if it doesn't have any updates to make
if necessary, these can be extracted to runtime arguments
alexdunnjpl
requested review from
tloubrieu-jpl,
nutjob4life and
collinss-jpl
as code owners
alexdunnjpl
force-pushed
the
70-data-version
branch
from
3ce7371 to
ecb261f
Compare
This was referenced Sep 12, 2023
tloubrieu-jpl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Implements a mechanism (in repairkit, but the approach is easily used elsewhere) to avoid redundant processing work. Previously, just no-op iterating through the initial query for repairkit was taking an inordinate amount of time. Now, only documents which haven't been updated with a version of repairkit GTE the current version are returned by the initial query.
For any sweeper, the sweeper version should be written as an integer to
f"ops:Provenance/ops:registry_sweepers_{sweeper_name}_version". This version should be updated in the sweeper'sconstantssubmodule whenever a change is made to the sweeper which invalidates previous processing of documents.Because it can only result from a code change in the first place, I've elected to hard-code the version in
constantsinstead of using a configuration file, for simplicity.Timeouts have been bumped to improve stability when run against prod registries. I've hardcoded them initially, but if they need to be changed a second time, I'll move them to a CLI argument.
There are additional unrelated changes/bugfixes included in this PR
⚙️ Test Data and/or Report
Manually tested against local, then en-prod (repairkit took 53min initially, and 0sec thereafter)
♻️ Related Issues
related to #61
fixes #70