Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multitenancy support #130

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Implement multitenancy support #130

merged 6 commits into from
Aug 26, 2024

Conversation

alexdunnjpl
Copy link
Contributor

@alexdunnjpl alexdunnjpl commented Aug 8, 2024

🗒️ Summary

Fixes outstanding issues with AOSS support

Wraps all instances of 'registry' and 'registry-refs' with a resolution function which returns an altered string iff env var MULTITENANCY_NODE_ID is set to a non-empty value

⚙️ Test Data and/or Report

Initially: Manually tested in the empty-value case. Tested in DEV MCP against registry-en-delta
Changes have been cherry-picked from #122, and not tested yet - must be tested manually in DEV MCP

♻️ Related Issues

fixes #120
related to #60

@alexdunnjpl
Copy link
Contributor Author

@jordanpadams @tloubrieu-jpl what's the priority on getting this tested and merged?

@jordanpadams jordanpadams changed the title implement multitenancy index pattern Implement multitenancy index pattern Aug 8, 2024
@jordanpadams
Copy link
Member

@alexdunnjpl let's talk about this at the breakout, but I added this ticket associated with this to the Registry API MVP. I really don't think we can deploy the API without have sweepers up an running (or at least the API will not work for several endpoints)

@alexdunnjpl alexdunnjpl marked this pull request as draft August 8, 2024 21:23
@alexdunnjpl
Copy link
Contributor Author

@jordanpadams I'll put testing this top-of-list, then

@alexdunnjpl
Copy link
Contributor Author

Testing blocked until EC2-attachable role created in MCP-PROD for use in tests.

@sjoshi-jpl has opened a ticket (could you link it here when you get a minute?) as only SAs have access.

sweepers policy will be temporarily attached to the new role to allow manual testing in EC2, then unattached once it's confirmed that sweepers can function with that policy.

@alexdunnjpl alexdunnjpl marked this pull request as ready for review August 26, 2024 20:30
@alexdunnjpl alexdunnjpl changed the title Implement multitenancy index pattern Implement multitenancy support Aug 26, 2024
@alexdunnjpl
Copy link
Contributor Author

alexdunnjpl commented Aug 26, 2024

Tested on MCP prod. Currently running against MCP indices to allow for immediate API deployment without blockage by ECS sweepers deployment. Blocked by VPN issues

@alexdunnjpl alexdunnjpl merged commit b4bae26 into main Aug 26, 2024
2 checks passed
@alexdunnjpl alexdunnjpl deleted the multitenant-merge branch August 26, 2024 22:38
@alexdunnjpl alexdunnjpl mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registry-sweeper upgrade for multitenant registry
3 participants