Add newly refactored /classes/{class} endpoint
#512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdunnjpl
force-pushed
the
classes-endpoints
branch
from
d72dc30 to
1475d1f
Compare
|
Need to investigate test failures - very confusing since there shouldn't be any overlap with the failing tests |
alexdunnjpl
added a commit
to NASA-PDS/registry
that referenced
this pull request
Jul 24, 2024
alexdunnjpl
added a commit
to NASA-PDS/registry
that referenced
this pull request
Jul 24, 2024
|
Failing tests are not currently valid and have been disabled in NASA-PDS/registry#301 per @tloubrieu-jpl (unless I've misunderstood) Good to go upon passing review |
alexdunnjpl
added a commit
to NASA-PDS/registry
that referenced
this pull request
Jul 24, 2024
alexdunnjpl
added a commit
to NASA-PDS/registry
that referenced
this pull request
Jul 24, 2024
jordanpadams
changed the title
/classes/{class} endpoint
|
@alexdunnjpl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Reimplements /classes and /classes/{class} API routes.
New implementation supports all PDS product classes
⚙️ Test Data and/or Report
Tests implemented for requirements in NASA-PDS/registry#302
♻️ Related Issues
Closes #461
Closes #511
Closes #488