Replace default string representation of Iterable fields with pipe-delimited format for some Accepts types #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdunnjpl
requested review from
tloubrieu-jpl and
al-niessner
as code owners
alexdunnjpl
force-pushed
the
375-csv-array-format
branch
2 times, most recently
from
55cc717 to
9e18908
Compare
…limited format affects application/csv, application/kvp+json, and text/csv return types fixes #375
alexdunnjpl
force-pushed
the
375-csv-array-format
branch
from
9e18908 to
6cbdf94
Compare
|
Two branch tests failures
Error 1 has a PR open. Error 2 appears to be unrelated to this PR and is probably the result of changes to test data. |
|
@tloubrieu-jpl @al-niessner could I trouble y'all for a review when you get a chance? |
tloubrieu-jpl
approved these changes
Oct 6, 2023
tloubrieu-jpl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affects application/csv, application/kvp+json, and text/csv return types fixes #375
🗒️ Summary
Previously, array-like properties would be formatted
[a, collection, of, elements]Now, they are formatted
a|collection|of|elements, per @tloubrieu-jpl request in #375⚙️ Test Data and/or Report
Manually tested
♻️ Related Issues
fixes #375