Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add membership metadata to provenance script #317

Closed
wants to merge 1 commit into from

Conversation

alexdunnjpl
Copy link
Contributor

really provenance should be renamed to reflect its expanded scope, but I don't want to complicate deployments just yet.

Opening PR to get the changes in there prior to moving across to new repository

🗒️ Summary

Brief summary of changes if not sufficiently described by commit messages.

⚙️ Test Data and/or Report

Manual test only - no CI/CD for provenance yet

♻️ Related Issues

related to #298 but doesn't resolve it, as the scope is changing (see new tickets in related epic)

really provenance should be renamed to reflect its expanded scope, but I don't want to complicate deployments just yet
extant_lidvids = get_extant_lidvids(host)
updates = get_successors_by_lidvid(extant_lidvids)
published_products = get_published_products(host)
log.info(f'Processing supporting metadata for all published products...')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3% of developers fix this issue

F541: f-string is missing placeholders


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? Answering this survey will not impact your Lift settings.

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

bulk_updates = chain(provenance_updates, membership_updates)
write_doc_updates(host, bulk_updates)

log.info(f'Finished processing supporting metadata for all published products!')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3% of developers fix this issue

F541: f-string is missing placeholders


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? Answering this survey will not impact your Lift settings.

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]


if updates:
write_updated_docs(host, updates)
successors_by_lidvid = get_successors_by_lidvid([p['lidvid'] for p in published_products])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1% of developers fix this issue

E501: line too long (94 > 79 characters)

❗❗ 15 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding
File Path Line Number
support/provenance/provenance.py 113
support/provenance/provenance.py 114
support/provenance/provenance.py 119
support/provenance/provenance.py 157
support/provenance/provenance.py 180
support/provenance/provenance.py 181
support/provenance/provenance.py 185
support/provenance/provenance.py 198
support/provenance/provenance.py 200
support/provenance/provenance.py 209

Showing 10 of 15 findings. Visit the Lift Web Console to see all.


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? Answering this survey will not impact your Lift settings.

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@alexdunnjpl
Copy link
Contributor Author

Closing due to migration of provenance functionality to https://github.com/NASA-PDS/registry-sweepers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant