Fixes #141 #147
Merged
Fixes #141 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
|
It is ready for you. Note that it is also been fixed on #142 as well. |
tloubrieu-jpl
approved these changes
Jul 5, 2022
Merged
al-niessner
pushed a commit
that referenced
this pull request
Jul 5, 2022
al-niessner
added a commit
that referenced
this pull request
Aug 16, 2022
* Issue 131: increase adaptability (#142) * endpoints Had to change the planned endpoints to /gid/{group name} to /pid/{lidvid}. Also had to add /gid and /pid as prefixes for the referencing endpoints as well. The point really is that had to add the prefixes is because swagger cannot tell /{group name} from /{lidvid} even though the group names are a well defined enum. The prefixes allow swagger to identify the endpoints as unique. While the actual characters gid and pid are not required, whatever is chosen must be unique and different. * reshape the architecture/design The base architecture is MVC, but the code does not directly represent it. Moved business to model and serializer to view to match the architecture. Reduced the multiple controllers to one and use a facade/plug-n-play pattern (ReferencingLogic) to manage the polymorphism needed for each of the ancestral paths to find information. Added a Java enum to do the mapping among the group names and the product class in the data itself. The enum holds the ReferencingLogic allowing either side (controller or model) to work with the given inputs and collect the desired output. Most of the code in the DAO objects moved to ReferencingLogic implementations. These objects understand the relationship between model elements and internalize the relationship as code. An example is for bundles finding their grandchildren. * CONTRIBUTING.md updated Once the refactoring was complete, updated the documentation to reflect the new code naming and its relationship to the architecture/design. * docker update by Jimmie Young <[email protected]> * Add a Dockerfile for building images for AWS deployments (#151) * Creation of AWS-specific Dockerfile, update README to indicate its purpose * Fix typo in both Dockerfiles (extraneous ']' in CMD) * Anonymous changes from main stomp * Switch back to 8080 by default (#157) * fix for 141 (#147) (#156) * changed string searching (#158) by Al Niessner <[email protected]> Seems that wildcards is not well implemented in the later elasticsearch and opensearch implementations. The most recent documentation for either has changed significantly that if searhing for strings, then they offer a short globish like set of patterns. Moved from using wildcards to this new string and it seems to be working. The eq operator had some problems because it was using should instead of filter for the or condition. SHould returns everything with a score value to represent the closes match from the furthest. Changed over to filter and the or condition is now behaving as expected. * Anonymous changes from main stomp * fixes for issue 162 * fixes for issue 162 * fix for issue 149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
It seems it is the swagger2 and springfox interaction that required a slightly different build to get the API documentation back. It has moved so updated
⚙️ Test Data and/or Report
♻️ Related Issues
#141 on release 1.0.1 branch