changes needed to support validate #519 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to be able to extract the length of a record requiring interface and then implementer updates. Found an error in the computation of bytes. Added more detail to the error messaging.
nutjob4life
reviewed
Jan 26, 2023
nutjob4life
approved these changes
Jan 26, 2023
jordanpadams
changed the title
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
NASA-PDS/validate#519 required changes during the read process when tables do not have the correct number of bytes in a file. Also, adding a new check in validation required the TableRecord interface to be updated which, in turn, required implementers of the the interface to be updated.
⚙️ Test Data and/or Report
See NASA-PDS/validate#589
♻️ Related Issues
NASA-PDS/validate#519