issue #57: radix is ignored #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The radix of the ASCII string is being ignored, Added it as a constructor parameter then fixed all creators. It is now explicit instead of assuming 10 which explains why the current tests passed - they assumed a radix of 10.
nutjob4life
approved these changes
Jan 5, 2023
|
@jordanpadams @nutjob4life @tloubrieu-jpl Ready for review |
jordanpadams
added a commit
to NASA-PDS/validate
that referenced
this pull request
Jan 5, 2023
jordanpadams
added a commit
to NASA-PDS/validate
that referenced
this pull request
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Brief summary of changes if not sufficiently described by commit messages.
⚙️ Test Data and/or Report
Added unit tests to detect the problem and they now pass (see first and last commit build reports on this PR)
♻️ Related Issues
#57