-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 4D arrays #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jbfaden! Thanks for the contribution.
I'd like to know more what's being accomplished here aside from the title. Is it possible to fill in the pull request template? All I see is the boilerplate text still.
This is the first time I've written a modification for someone else's code. Where is the pull request template? I'm working with Jordan, and I see that the library supports 3-index arrays of data but not 4-index arrays. It now supports them as well. |
@jbfaden oh, great! So happy to have your help. Thanks for the explanation. That helps me understand the purpose. FYI, the template is this text that appears at the top of your pull request; see this screenshot: If you click the ⋯ and choose "Edit", you can replace the text like In any case, this looks fine, so I'm adding my stamp of approval 👍 |
Okay, thanks for pointing that out. Look forward to the next one! |
@jbfaden do you have an example product that we can add to our validate regression tests to ensure we can check these? If you have one that should fail, that would be excellent as well! |
Joe has one, which I assume I could make available to you. I'll ask him. |
@jordanpadams sorry if I merged this too quickly—I was excited by this contribution 😊 |
🗒️ Summary
This adds support for 4-index arrays.
⚙️ Test Data and/or Report
test4DDouble() of ArrayObjectTest tests this code.
♻️ Related Issues