Fix #795 test data and add test case for #816

NASA-PDS · Nov 9, 2024 · 6f3cfba · 6f3cfba
1 parent dafed5e
commit 6f3cfba
Show file tree

Hide file tree

Showing 6 changed files with 99 additions and 12,043 deletions.
diff --git a/model-lddtool/src/test/resources/features/validate.feature b/model-lddtool/src/test/resources/features/validate.feature
@@ -1,6 +1,6 @@
-Feature: Running integration tests for validate module
+Feature: pds4_information_model_integration
 
-  Scenario Outline: Execute validate command for tests below.
+  Scenario Outline: <testId>
     Given the test <testName> at directory <testDir>
     Given the latest PDS4 schema/schematron is generated
     Given a new LDD is generated using the IngestLDDs <ingestLDDFileName>
@@ -14,13 +14,14 @@ Feature: Running integration tests for validate module
 
     @v15.2.x
     Examples: 
-      | testName | testDir     | messageCount | messageText         | problemEnum        | commandArgs                                             | ingestLDDFileName         |
-      # NOTE: as of 10/18/2024, this fails
-      | "NASA-PDS/pds4-information-model#795 Test Schematron 1"  | "github795" |           9 | "9 errors expected" | "SCHEMATRON_ERROR" | "--rule pds4.bundle --target {resourceDir}/github795/" | "" |
+      | testId | testName | testDir     | messageCount | messageText         | problemEnum        | commandArgs                                             | ingestLDDFileName         |
+      | "NASA-PDS/pds4-information-model#795a" | "Expected reference_type Failures for all Data Types"       | "github795" |           9 | "9 errors expected" | "SCHEMATRON_ERROR" | "--rule pds4.bundle --target {resourceDir}/github795/" | "" |
 
-      | "NASA-PDS/pds4-information-model#795 Test Schematron 2"  | "github795b" |           1 | "1 errors expected" | "SCHEMATRON_ERROR" | "--target {resourceDir}/github795b/" | "" |
+      | "NASA-PDS/pds4-information-model#795b"| "Expected reference_type Failure for Product_External"       | "github795b" |           1 | "1 errors expected" | "SCHEMATRON_ERROR" | "--target {resourceDir}/github795b/" | "" |
 
-      | "NASA-PDS/pds4-information-model#797 Test Schematron 1"  | "github797" |            3 | "3 errors expected" | "SCHEMATRON_ERROR" | "--target {resourceDir}/github797/test_label1_FAIL.xml {resourceDir}/github797/u5.xml" | "PDS4_GEOM_IngestLDD.xml" |
+      | "NASA-PDS/pds4-information-model#797" | "Expected schematron failure for kernel_type values"         | "github797" |            3 | "3 errors expected" | "SCHEMATRON_ERROR" | "--target {resourceDir}/github797/test_label1_FAIL.xml {resourceDir}/github797/u5.xml" | "PDS4_GEOM_IngestLDD.xml" |
+
+      | "NASA-PDS/pds4-information-model#816" | "Expected failure for Product_External LID formation rule"   | "github816" |            1 | "1 errors expected" | "SCHEMATRON_ERROR" | "--target {resourceDir}/github816/" | "" |