Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Data selector modal work #1213

Open
wants to merge 4 commits into
base: 902-ea-breakout
Choose a base branch
from
Open

Conversation

hanbyul-here
Copy link
Collaborator

@hanbyul-here hanbyul-here commented Oct 23, 2024

Related Ticket: #1156

Description of Changes

  • The main reason the data selector modal was not working is ~ again ~ link-related components error. I made it use linkProperties props.
  • I also moved LinkProperties type to types/veda

Notes & Questions About Changes

I will inline-comment

Validation / Testing

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit ce6bd1c
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/671a8ba571dd2400083de190
😎 Deploy Preview https://deploy-preview-1213--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

linkProperties = {
linkTo,
onLinkClick,
onClick,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consolidated onLinkClick to onClick - so this can be attached to the LinkElement directly when needed.

@hanbyul-here hanbyul-here marked this pull request as ready for review October 24, 2024 17:37
@hanbyul-here hanbyul-here requested review from sandrahoang686 and dzole0311 and removed request for sandrahoang686 October 24, 2024 17:38
@dzole0311
Copy link
Collaborator

The main reason the data selector modal was not working is ~ again ~ link-related components error. I made it use linkProperties props.

🤯

Copy link
Collaborator

@dzole0311 dzole0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

veda-ui:

  1. Modal opens/closes as expected ✅
  2. Links in the modal work (e.g the link in the empty state) ✅

next.js

  1. the modal opens as expected ✅
  2. datasets are shown ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants