-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Data selector modal work #1213
base: 902-ea-breakout
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
linkProperties = { | ||
linkTo, | ||
onLinkClick, | ||
onClick, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I consolidated onLinkClick
to onClick
- so this can be attached to the LinkElement directly when needed.
69d93b1
to
f7a4284
Compare
🤯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
veda-ui:
- Modal opens/closes as expected ✅
- Links in the modal work (e.g the link in the empty state) ✅
next.js
- the modal opens as expected ✅
- datasets are shown ✅
Related Ticket: #1156
Description of Changes
linkProperties
props.LinkProperties
type totypes/veda
Notes & Questions About Changes
I will inline-comment
Validation / Testing