Fix map controls and resolve Analyses Message issue

[dzole0311]

Related Ticket: #1155 #1172

Related Next.js PR: developmentseed/next-veda-ui#7

Description of Changes

• Fixed the map controls so that they work in the Next.js instance
• Resolve issue with the Analyses Message display
• Attempted to address the React mount error mentioned in Clean up the themed controls when unmounted #1172

Notes & Questions About Changes

{Add additonal notes and outstanding questions here related to changes in this pull request}

Validation / Testing

1. Verify that the AOI controls and Analyses Message work as expected in both veda-ui and the Next.js instance
2. Verify that adding, deleting a single drawn area, or deleting all drawn areas works without issues
3. Ensure that analyses execute as expected

[netlify]

✅ Deploy Preview for veda-ui ready!

Name	Link
🔨 Latest commit	588fd8b
🔍 Latest deploy log	https://app.netlify.com/sites/veda-ui/deploys/671b6038f3906400084588b1
😎 Deploy Preview	https://deploy-preview-1205--veda-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[hanbyul-here]

Ah, I see; so the problem was that we couldn't guarantee that the map was loaded before registering mapbox-draw-related events?

[dzole0311]

Yes, I think the issue came from two places:

1. We couldn’t guarantee the map was fully loaded before adding the Mapbox Draw events. So I added this check to make sure main.loaded() is true before switching modes when DrawControl is initialized
2. There was a strange synchronization issue in the previous code that initialized useControl. Specifically control.current was undefined later in the CustomAoiControl and adding safeguards or null checks didn't fix the problem. So I ended up assigning the control instance returned by useControl directly to a variable (like const drawControl = useControl(...)) to make sure we're always using the correct and initialized control instance

[hanbyul-here]

oh- interesting. It will be great to figure out why 2. is happening (not a blocker, though!)

[hanbyul-here]

oh- interesting. It will be great to figure out why 2. is happening (not a blocker, though!)

[sandrahoang686]

Seems like changeDrawMode is getting called no matter what, do we want that? I'm wondering can we check for the isDrawing bool earlier - on line 330? Then this kind of makes the if/else with defaulting to simple_select obsolete but did that do anything anyways? I checked locally and if we got rid of that logic, seems like everything still works as is but I may be missing something 🤔

[dzole0311]

The original commit addressed an issue where polygons were not being selected after completing the drawing by double-clicking. I tried this and it is reproducible locally using this line.

However you're correct that the switch to simple_select mode is redundant as it seems to be managed internally by Mapbox Draw GL (note: the explicit switch might have been needed back when the fix was implemented). So this behavior makes chunks of the code unnecessary. I removed the obsolete parts and added a comment.