Fixing collecton ingest DAG #261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ividito
requested changes
Nov 25, 2024
Comment on lines
+56
to
+61
| run_discover_build_and_push = TriggerMultiDagRunOperator( | ||
| task_id="trigger_discover_items_dag", | ||
| dag=dag, | ||
| trigger_dag_id="veda_discover", | ||
| python_callable=trigger_discover_and_build_task, | ||
| ) |
There was a problem hiding this comment.
We should not use this operator, as it creates a disconnect between the original DAGRun event and subsequent DAG runs (ie. a failure in an instance veda-discover will not feed back to the original veda-dataset DAG using this operator). We could instead describe the discover pipeline in a TaskGroup and call expand() on it, which will map task instances to the correct event.
There was a problem hiding this comment.
I want to re-use discover_build_ingest DAG instead of redefining the same tasks. But having a task group used in both DAGs is not a bad idea
anayeaye
reviewed
Nov 25, 2024
| @@ -41,7 +41,9 @@ COPY --chown=airflow:airflow scripts "${AIRFLOW_HOME}/scripts" | |||
|
|
|||
| RUN cp ${AIRFLOW_HOME}/configuration/airflow.cfg* ${AIRFLOW_HOME}/. | |||
|
|
|||
| RUN pip install pypgstac==0.7.4 | |||
| # Commited because it downgrade pydentics to v1 | |||
There was a problem hiding this comment.
This is an artifact and we should not need pypgstac in airflow--that should be entirely handled by the ingest api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
Fixing collection ingest
Changes