Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

so2 volcano story #130

Merged
merged 27 commits into from
Jan 25, 2023
Merged

so2 volcano story #130

merged 27 commits into from
Jan 25, 2023

Conversation

hanbyul-here
Copy link
Collaborator

@hanbyul-here hanbyul-here commented Nov 4, 2022

Add so2 volcano story (air quality)

@netlify
Copy link

netlify bot commented Nov 4, 2022

Deploy Preview for visex ready!

Name Link
🔨 Latest commit afb7171
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/636819f18a0aff000873af28
😎 Deploy Preview https://deploy-preview-130--visex.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 1, 2022

Deploy Preview for visex ready!

Name Link
🔨 Latest commit 2d600b3
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/63d16c37cc18a800089d9378
😎 Deploy Preview https://deploy-preview-130--visex.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aboydnw
Copy link
Contributor

aboydnw commented Jan 5, 2023

@kcarini I just requested reviews from Daniel and Erik. I'd say if this is good to go then we JFDI it. I can ask for forgiveness later if something ends up being super wrong

@hanbyul-here hanbyul-here changed the title [do not merge this] so2 volcano story so2 volcano story Jan 5, 2023
@hanbyul-here hanbyul-here marked this pull request as ready for review January 5, 2023 21:22
@hanbyul-here
Copy link
Collaborator Author

I noticed storytelling map jumps instead animates between the points. Did we change the behavior of the component at one point? or is this the bug that we didn't catch before? @danielfdsilva ?
(This behavior was not introduced by this pr, and should not be a blocker)

I also tried adjusting chapter fields within the scrollytelling block but it wasn't changing the date, zoom or lat/long - like I didn't see changes I made being reflected when I saved it.
@kcarini
Copy link
Collaborator

kcarini commented Jan 5, 2023

I noticed storytelling map jumps instead animates between the points. Did we change the behavior of the component at one point? or is this the bug that we didn't catch before? @danielfdsilva ? (This behavior was not introduced by this pr, and should not be a blocker)

I tried adjusting some of the field attributes in this scrollytelling block and wasn't noticing the changes being reflected in my local instance.

Copy link
Collaborator

@danielfdsilva danielfdsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images updated

@aboydnw
Copy link
Contributor

aboydnw commented Jan 7, 2023

@danielfdsilva @hanbyul-here can you check @kcarini 's scrollytelling configuration? Sounds like she was trying to adjust to location show in each frame but it didn't change. Looking at the preview, it hovers over the same spots as before she made her changes. Once we sort that out, I think this is ready to merge.

adjusted locations in the scrollytelling block and added some location identified text in each chapter.
@kcarini
Copy link
Collaborator

kcarini commented Jan 17, 2023

I looked at the scrollytelling block again and I have a better understanding of the formatting. I actually used the SO2 Dataset Exploration to help me quickly identify some years and locations to highlight in the scrollytelling block. While the locations aren't directly related to the text, I added a sentence in each chapter text describing the location and year. I don't think that people will necessarily notice the year changing as they scroll. It may be a best practice to not change the year of a dataset in the scrollytelling block unless we can make is more obvious. But for now I reiterated it in the text.

For some reason the dataset is not rendering in the chapter for 2009 centered on the Kamchatka Peninsula.

@aboydnw
Copy link
Contributor

aboydnw commented Jan 17, 2023

Thanks @kcarini ! I'm not sure why that 2009 frame isn't showing up either. I'll let @danielfdsilva @hanbyul-here troubleshoot.

I did just make the discovery a featured discovery. I think most the discoveries we publish at this point should be featured discoveries. Until we reach a point where we have a) lots of content or b) another way for us to showcase "recently added" discoveries like IMPACT has asked for. This is a little lower priority than some of the other work we have on deck, though, so I propose this as a standard practice until then.

@danielfdsilva
Copy link
Collaborator

@kcarini I think you're right that the changes are not super clear, especially when moving to a different place and loading different data. The text should help describe what's on the map. Ideally the map could be removed and the text would still make sense.

@netlify
Copy link

netlify bot commented Jan 18, 2023

Dee-Dee Teklu left a comment:

screenshot

Browser metadata
Path:      /air-quality/discoveries/so2-volcanoes
Browser:   Chrome 109.0.0.0 on Windows 10
Viewport:  1280 x 609 @1.5x
Language:  en-US
Cookies:   Disabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@netlify
Copy link

netlify bot commented Jan 18, 2023

Dee-Dee Teklu left a comment:

NASA's satellites and instruments track volcanic emissions and its impact on global air quality.

Browser metadata
Path:      /air-quality/discoveries/so2-volcanoes
Browser:   Chrome 109.0.0.0 on Windows 10
Viewport:  1280 x 609 @1.5x
Language:  en-US
Cookies:   Disabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@netlify
Copy link

netlify bot commented Jan 18, 2023

Dee-Dee Teklu left a comment:

screenshot

Browser metadata
Path:      /air-quality/discoveries/so2-volcanoes
Browser:   Chrome 109.0.0.0 on Windows 10
Viewport:  1280 x 609 @1.5x
Language:  en-US
Cookies:   Disabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@kcarini
Copy link
Collaborator

kcarini commented Jan 18, 2023

Comments from DeeDee on changing a few text things:

Please use this version for subtitle
NASA monitors volcanic emissions and its impact on global air quality

Watching lava and magma flow from an erupting volcano may seem fascinating at first sight. But volcanoes emit dangerous gasses, including sulfur dioxide (SO₂), which can be toxic to the human body and the environment. (The picture to the right should match this paragraph. Ex. Lava bubbling out of a volcano)

The role of volcanic activity in sulfuric emissions

I'll make these changes.

@aboydnw
Copy link
Contributor

aboydnw commented Jan 18, 2023

Once these changes are made, we got approval from Dee-Dee to push to production, so this can be including in our next production push @danielfdsilva

@kcarini
Copy link
Collaborator

kcarini commented Jan 20, 2023

@danielfdsilva @aboydnw I've made DeeDee's requested changes, so I think it is good to go.

addressed @hanbyul-here comments
@hanbyul-here hanbyul-here merged commit 67e1b68 into develop Jan 25, 2023
@hanbyul-here hanbyul-here deleted the discovery/so2volcanoes branch January 25, 2023 18:12
This was referenced Feb 2, 2023
siddharth0248 pushed a commit that referenced this pull request Apr 26, 2024
Give InitialDatetime properties to all layers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants