-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
so2 volcano story #130
so2 volcano story #130
Conversation
✅ Deploy Preview for visex ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
afb7171
to
0eef8db
Compare
✅ Deploy Preview for visex ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@kcarini I just requested reviews from Daniel and Erik. I'd say if this is good to go then we JFDI it. I can ask for forgiveness later if something ends up being super wrong |
I noticed storytelling map jumps instead animates between the points. Did we change the behavior of the component at one point? or is this the bug that we didn't catch before? @danielfdsilva ? |
I also tried adjusting chapter fields within the scrollytelling block but it wasn't changing the date, zoom or lat/long - like I didn't see changes I made being reflected when I saved it.
I tried adjusting some of the field attributes in this scrollytelling block and wasn't noticing the changes being reflected in my local instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Images updated
@danielfdsilva @hanbyul-here can you check @kcarini 's scrollytelling configuration? Sounds like she was trying to adjust to location show in each frame but it didn't change. Looking at the preview, it hovers over the same spots as before she made her changes. Once we sort that out, I think this is ready to merge. |
adjusted locations in the scrollytelling block and added some location identified text in each chapter.
I looked at the scrollytelling block again and I have a better understanding of the formatting. I actually used the SO2 Dataset Exploration to help me quickly identify some years and locations to highlight in the scrollytelling block. While the locations aren't directly related to the text, I added a sentence in each chapter text describing the location and year. I don't think that people will necessarily notice the year changing as they scroll. It may be a best practice to not change the year of a dataset in the scrollytelling block unless we can make is more obvious. But for now I reiterated it in the text. For some reason the dataset is not rendering in the chapter for 2009 centered on the Kamchatka Peninsula. |
Thanks @kcarini ! I'm not sure why that 2009 frame isn't showing up either. I'll let @danielfdsilva @hanbyul-here troubleshoot. I did just make the discovery a featured discovery. I think most the discoveries we publish at this point should be featured discoveries. Until we reach a point where we have a) lots of content or b) another way for us to showcase "recently added" discoveries like IMPACT has asked for. This is a little lower priority than some of the other work we have on deck, though, so I propose this as a standard practice until then. |
@kcarini I think you're right that the changes are not super clear, especially when moving to a different place and loading different data. The text should help describe what's on the map. Ideally the map could be removed and the text would still make sense. |
Dee-Dee Teklu left a comment: Browser metadata
|
Dee-Dee Teklu left a comment: NASA's satellites and instruments track volcanic emissions and its impact on global air quality. Browser metadata
|
Dee-Dee Teklu left a comment: Browser metadata
|
Comments from DeeDee on changing a few text things:
I'll make these changes. |
Once these changes are made, we got approval from Dee-Dee to push to production, so this can be including in our next production push @danielfdsilva |
@danielfdsilva @aboydnw I've made DeeDee's requested changes, so I think it is good to go. |
addressed @hanbyul-here comments
Co-authored-by: Daniel da Silva <[email protected]>
Give InitialDatetime properties to all layers
Add so2 volcano story (air quality)