Update cmr mappings #1102
Open
Update cmr mappings #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
1051-backend-model-changes-on-cosmos-to-hold-new-incoming-urls-frontend
to
dev
November 21, 2024 14:15
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| def test_sde_link_generation(self): | ||
| data = {"meta": {"concept-id": "C179001887-SEDAC"}} | ||
| dataset = CmrDataset(data) | ||
| assert "sciencediscoveryengine.nasa.gov" in dataset.sde_link |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 11 days ago
To fix the problem, we need to parse the URL and check the hostname to ensure it matches the expected value. This can be done using the urlparse function from the urllib.parse module. We will extract the hostname from the URL and verify that it matches "sciencediscoveryengine.nasa.gov".
- Parse the URL using
urlparse. - Extract the hostname from the parsed URL.
- Check if the hostname matches "sciencediscoveryengine.nasa.gov".
Suggested changeset
1
scripts/ej/test_cmr_processing.py
| @@ -450,3 +450,5 @@ | ||
| dataset = CmrDataset(data) | ||
| assert "sciencediscoveryengine.nasa.gov" in dataset.sde_link | ||
| from urllib.parse import urlparse | ||
| parsed_url = urlparse(dataset.sde_link) | ||
| assert parsed_url.hostname == "sciencediscoveryengine.nasa.gov" | ||
| assert "C179001887-SEDAC" in dataset.sde_link |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.