Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base64 to gemspec #697

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

ltickett
Copy link
Contributor

@ltickett ltickett commented Aug 14, 2024

When using this Gem in Ruby 3.3.4 i'm getting this warning:

/builds/gitlab-community/meta/vendor/ruby/3.3.0/gems/gitlab-5.0.0/lib/gitlab/cli_helpers.rb:5: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of gitlab-5.0.0 to add base64 into its gemspec.

I noticed we can also see this in checks in this in checks like: https://github.com/NARKOZ/gitlab/actions/runs/10246689948/job/28344330836?pr=695#step:4:92

We can see this no longer appears in the checks for this PR: https://github.com/NARKOZ/gitlab/actions/runs/10390243537/job/28770239632?pr=697#step:4:93

@ltickett
Copy link
Contributor Author

@NARKOZ would you mind taking a look at this PR please?

@NARKOZ NARKOZ merged commit 080bc60 into NARKOZ:master Aug 14, 2024
4 checks passed
@NARKOZ
Copy link
Owner

NARKOZ commented Aug 14, 2024

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants