Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 implementation of multiple fiware service support #31

Merged
merged 17 commits into from
Sep 24, 2024

Conversation

Bhavdeep13
Copy link
Collaborator

"feat: Implementation of multiple FIWARE service support"

@Bhavdeep13 Bhavdeep13 requested a review from djs0109 July 8, 2024 13:06
@Bhavdeep13 Bhavdeep13 linked an issue Jul 8, 2024 that may be closed by this pull request
@djs0109
Copy link
Contributor

djs0109 commented Jul 16, 2024

@Bhavdeep13 I solve the most conflict. Please check the Form.svelte and Table.svelte again. For them I just accept your changes in branch 11

@Bhavdeep13
Copy link
Collaborator Author

I have checked, it looks fine

@djs0109
Copy link
Contributor

djs0109 commented Jul 16, 2024

@Bhavdeep13, can you implement a unit test in test_forwarding that validates the expected behavior of using different firmware services?

@Bhavdeep13
Copy link
Collaborator Author

I already did that in test_crud.py, but in the latest push I have updated them in test_forwarding,py

@djs0109
Copy link
Contributor

djs0109 commented Sep 24, 2024

@Bhavdeep13 I actually mean something like that cf2a002. I have implemented them now.

@djs0109 djs0109 merged commit dab20c8 into main Sep 24, 2024
2 checks passed
@djs0109 djs0109 deleted the 11-implementation-of-multiple-fiware-service-support branch September 24, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of multiple FIWARE service support
2 participants