-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Add fields to warcinfo #22
Comments
N0taN3rd
added a commit
that referenced
this issue
Dec 15, 2018
longer require including the extension in the name for the WARC file to be created, it will be added if it is omitted allow the default WARC file option can now be supplied as the only argument to the constructor of all writers or set via prep for v3.2.0 release
Tested commit 0de56e6 and everything seems to work fine, feature added. |
N0taN3rd
added a commit
that referenced
this issue
Dec 28, 2018
longer require including the extension in the name for the WARC file to be created, it will be added if it is omitted allow the default WARC file option can now be supplied as the only argument to the constructor of all writers or set via treat the post data retrieved via `Network.getRequestPostData` as utf-8 strings rather than base64 encoded strings Added to all writers the ability to write a Webrecorder Player compatible bookmark list (as WARC info record) via WARCWriterBase.writeWebrecorderBookmarksInfoRecord and the pages property of the genOpts object supplied to generateWARC fixes #25 update index.d.ts with 3.2.0 changes
N0taN3rd
added a commit
that referenced
this issue
Dec 28, 2018
Allow full control over the contents of the WARC info record fixes #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The spec says:
Currently it just admits the isPartOf, UserAgent and description. It would be useful to add software-based fields, to change the robots fields and to add some extra info to the software line.
node-warc/lib/writers/warcFields.js
Lines 175 to 189 in 09a8a0b
The text was updated successfully, but these errors were encountered: