Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: err not updated after OTP authentication #21

Merged
merged 1 commit into from
May 28, 2023

Conversation

idawnlight
Copy link
Contributor

Previously, err was not updated after client.AuthSMSCode(smsCode) or client.AuthTOTP(TOTPCode). As a result, even after successful authentication, the code would still panic at core/EasyConnectClient.go#L118:

	// check error after trying best server
	if err != nil {
		log.Fatal(err.Error())
	}

Copy link
Collaborator

@cxz66666 cxz66666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@cxz66666 cxz66666 merged commit 4d16b55 into Mythologyli:main May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants