enable -Wundef for C++ code #456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<cstdint> is used unconditionally in the file, so remove the unnecessary checks
The other uses were already ifdef.
HAVE_GETOPT_H is never defined and getopt is not used in this file, so remove all of it.
SoundTouch is detected with pkgconfig, which on Ubuntu has:
includedir=${prefix}/include
Cflags: -I${includedir}/soundtouch
GCC sees SoundTouch.h as a non-system header and gives warnings for -Wundef.
/usr/include/soundtouch/STTypes.h:81:11: warning: "SOUNDTOUCH_INTEGER_SAMPLES" is not defined, evaluates to 0 [-Wundef]
81 | #if !(SOUNDTOUCH_INTEGER_SAMPLES || SOUNDTOUCH_FLOAT_SAMPLES)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/soundtouch/STTypes.h:102:10: warning: "_M_IX86" is not defined, evaluates to 0 [-Wundef]
102 | #if (_M_IX86 || __i386__ || __x86_64__ || _M_X64)
| ^~~~~~~
/usr/include/soundtouch/STTypes.h:102:21: warning: "__i386__" is not defined, evaluates to 0 [-Wundef]
102 | #if (_M_IX86 || __i386__ || __x86_64__ || _M_X64)
Including as <soundtouch/SoundTouch.h> suppresses the warnings, since GCC now sees it as a system header.
by removing the dts seeking hack, which hasn't compiled since the FFmpeg 5.1 merge, which moved AVStream::cur_dts to the internal struct FFStream.
Disable -Wundef for external/libexiv2/ because of noise from xmpsdk/include/*
|
Merged into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable -Wundef for external/libexiv2/ because of noise from
xmpsdk/include/*.See individual commits for details.